[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason
From: Marco Martin <notmart () gmail ! com>
Date: 2016-02-29 13:27:03
Message-ID: 20160229132703.32153.60162 () mimi ! kde ! org
[Download RAW message or body]
--===============4530679207779724700==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 1:27 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit f55e20cc5fe74af927258541269f29246c6cec21 by Marco Martin to \
branch master.
Repository: plasma-framework
Description
-------
unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface as \
properties.
It would still need somewhere the creation of graphics for that, probably in the \
containments code.
Diffs
-----
src/plasma/applet.h df57e94
src/plasma/applet.cpp 4ce2d28
src/plasma/private/applet_p.h e1aaef6
src/plasma/private/applet_p.cpp 949c92e
src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08
src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d
Diff: https://git.reviewboard.kde.org/r/127218/diff/
Testing
-------
Thanks,
Marco Martin
--===============4530679207779724700==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127218/">https://git.reviewboard.kde.org/r/127218/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2016, 1:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f55e20cc5fe74af927258541269f29246c6cec21 by Marco \
Martin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">unbreak api of Applet::SetConfigurationRequired + add \
bindings to appletInterface as properties.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It would still need \
somewhere the creation of graphics for that, probably in the containments \
code.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/applet.h <span style="color: grey">(df57e94)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(4ce2d28)</span></li>
<li>src/plasma/private/applet_p.h <span style="color: grey">(e1aaef6)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(949c92e)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(8dcac08)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(550438d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127218/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4530679207779724700==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic