From kde-panel-devel Mon Feb 29 12:59:49 2016 From: Marco Martin Date: Mon, 29 Feb 2016 12:59:49 +0000 To: kde-panel-devel Subject: Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray Message-Id: <20160229125949.32153.71203 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145675080516550 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5383435543252977929==" --===============5383435543252977929== Content-Type: multipart/alternative; boundary="===============8312161838497273271==" --===============8312161838497273271== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/#review92901 ----------------------------------------------------------- Ship it! Ship It! - Marco Martin On Feb. 29, 2016, 12:57 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126811/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 12:57 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Normally done by the containment interface > > BUG: 358119 > > > Diffs > ----- > > applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 1afaf145bace331f39405d044590c6b0688146af > > Diff: https://git.reviewboard.kde.org/r/126811/diff/ > > > Testing > ------- > > Literally none. I assume Kai has something. > > > Thanks, > > David Edmundson > > --===============8312161838497273271== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/

Ship it! 

Ship It!

- Marco Martin


On February 29th, 2016, 12:57 p.m. UTC, David Edmundson wrote:

Review request for Plasma.
By David Edmundson.

Updated Feb. 29, 2016, 12:57 p.m.

Repository: plasma-workspace

Description 

Normally done by the containment interface


BUG: 358119

Testing 

Literally none. I assume Kai has something.

Diffs

  • applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp (1afaf145bace331f39405d044590c6b0688146af)

View Diff
--===============8312161838497273271==-- --===============5383435543252977929== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5383435543252977929==--