[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason
From: Marco Martin <notmart () gmail ! com>
Date: 2016-02-29 12:28:58
Message-ID: 20160229122858.32153.16337 () mimi ! kde ! org
[Download RAW message or body]
--===============6334589769994687187==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 29, 2016, 12:19 p.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76
> > <https://git.reviewboard.kde.org/r/127218/diff/1/?file=445992#file445992line75>
> >
> > why copy the string?
>
> Kai Uwe Broulik wrote:
> We need a getter for this.
yeah, i tried to do without adding a getter in Applet, adding it now, it should make \
things easier
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127218/#review92895
-----------------------------------------------------------
On Feb. 29, 2016, 12:15 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127218/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 12:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> unbreak api of Applet::SetConfigurationRequired + add bindings to appletInterface \
> as properties.
>
> It would still need somewhere the creation of graphics for that, probably in the \
> containments code.
>
> Diffs
> -----
>
> src/plasma/applet.h df57e94
> src/plasma/applet.cpp 4ce2d28
> src/plasma/private/applet_p.h e1aaef6
> src/plasma/private/applet_p.cpp 949c92e
> src/scriptengines/qml/plasmoid/appletinterface.h 8dcac08
> src/scriptengines/qml/plasmoid/appletinterface.cpp 550438d
>
> Diff: https://git.reviewboard.kde.org/r/127218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============6334589769994687187==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127218/">https://git.reviewboard.kde.org/r/127218/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 29th, 2016, 12:19 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127218/diff/1/?file=445992#file445992line75" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scriptengines/qml/plasmoid/appletinterface.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">m_configurationRequiredReason</span> <span class="o">=</span> <span \
class="n">reason</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">76</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">emit</span> <span class="nf">configurationRequiredChanged</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why \
copy the string?</p></pre> </blockquote>
<p>On February 29th, 2016, 12:26 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
need a getter for this.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yeah, i tried to do without adding a getter in Applet, adding it now, it \
should make things easier</p></pre> <br />
<p>- Marco</p>
<br />
<p>On February 29th, 2016, 12:15 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2016, 12:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">unbreak api of Applet::SetConfigurationRequired + add \
bindings to appletInterface as properties.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It would still need \
somewhere the creation of graphics for that, probably in the containments \
code.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/applet.h <span style="color: grey">(df57e94)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(4ce2d28)</span></li>
<li>src/plasma/private/applet_p.h <span style="color: grey">(e1aaef6)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(949c92e)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.h <span style="color: \
grey">(8dcac08)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(550438d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127218/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6334589769994687187==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic