'Re: Review Request 127217: Move contextualActionsAboutToShow to Applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127217: Move contextualActionsAboutToShow to Applet
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-02-29 12:10:32
Message-ID: 20160229121032.32153.41510 () mimi ! kde ! org
[Download RAW message or body]

--===============2680954533154715100==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127217/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 12:10 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Changes
-------

Submitted with commit 88ec6de11392710df72f2bab6139dc385596743a by David Edmundson to \
branch master.

Repository: plasma-framework

Description
-------

Applet contains the menu actions, therefore notifying the menu needs updating should
happen in Applet not AppletInterface. With AppletInterface being a dumb
wrapper.

This exposes functionality to anyone who overrides Applet, but also will
also allows system tray to emit this signal without having to use
private API.

This is a better version of my patch at https://git.reviewboard.kde.org/r/126811/ to \
fix 358119 that I wasn't happy with.

Diffs
-----

  src/plasma/applet.h df57e945b7dcd3b907c68ae82e5a26f2caeb5c9f 
  src/scriptengines/qml/plasmoid/appletinterface.cpp \
550438d05640cc02a1a2bda546601e6740a9b4e9   \
src/scriptengines/qml/plasmoid/containmentinterface.cpp \
44ed56ed85adec4af054a25c1cc5b46605152320 

Diff: https://git.reviewboard.kde.org/r/127217/diff/

Testing
-------

Thanks,

David Edmundson

--===============2680954533154715100==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127217/">https://git.reviewboard.kde.org/r/127217/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Feb. 29, 2016, 12:10 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 88ec6de11392710df72f2bab6139dc385596743a by David \
Edmundson to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Applet contains the menu actions, therefore notifying \
the menu needs updating should happen in Applet not AppletInterface. With \
AppletInterface being a dumb wrapper.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This exposes functionality to anyone who overrides \
Applet, but also will also allows system tray to emit this signal without having to \
use private API.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a better version of my patch at \
https://git.reviewboard.kde.org/r/126811/ to fix 358119 that I wasn't happy \
with.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasma/applet.h <span style="color: \
grey">(df57e945b7dcd3b907c68ae82e5a26f2caeb5c9f)</span></li>

 <li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(550438d05640cc02a1a2bda546601e6740a9b4e9)</span></li>

 <li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(44ed56ed85adec4af054a25c1cc5b46605152320)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127217/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2680954533154715100==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 