[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127201: Fix svg icon path resolving in IconItem
From: Marco Martin <notmart () gmail ! com>
Date: 2016-02-29 9:27:52
Message-ID: 20160229092752.32153.1187 () mimi ! kde ! org
[Download RAW message or body]
--===============3408386335214584800==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127201/#review92886
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Feb. 28, 2016, 5:15 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127201/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 5:15 p.m.)
>
>
> Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and Marco \
> Martin.
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Well.. the bug should be obvious:
> 1. QString iconPath overrides the iconPath in a higher scope. introduced in \
> https://git.reviewboard.kde.org/r/126168/ 2. iconPath not assigned, also introduced \
> in https://git.reviewboard.kde.org/r/126168/ 3. svgz -> svg?? introduced in \
> https://git.reviewboard.kde.org/r/126557/
>
> Diffs
> -----
>
> autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg PRE-CREATION
> autotests/data/icons/hicolor/22x22/apps/bug359388.svg 8739af5
> autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg \
> PRE-CREATION autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg \
> PRE-CREATION autotests/data/icons/test-theme/apps/48/konversation.svg PRE-CREATION \
> autotests/data/icons/test-theme/index.theme PRE-CREATION
> autotests/iconitemtest.h 9fd3063
> autotests/iconitemtest.cpp ea98c9d
> src/declarativeimports/core/iconitem.cpp c65a9a7
>
> Diff: https://git.reviewboard.kde.org/r/127201/diff/
>
>
> Testing
> -------
>
> tested with qmlscene with Plasma.IconItem.
>
>
> Thanks,
>
> Xuetian Weng
>
>
--===============3408386335214584800==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127201/">https://git.reviewboard.kde.org/r/127201/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Marco Martin</p>
<br />
<p>On February 28th, 2016, 5:15 p.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and \
Marco Martin.</div> <div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2016, 5:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Well.. the bug should be obvious: 1. QString iconPath \
overrides the iconPath in a higher scope. introduced in \
https://git.reviewboard.kde.org/r/126168/ 2. iconPath not assigned, also introduced \
in https://git.reviewboard.kde.org/r/126168/ 3. svgz -> svg?? introduced in \
https://git.reviewboard.kde.org/r/126557/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tested with qmlscene with Plasma.IconItem.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style="color: \
grey">(8739af5)</span></li>
<li>autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/apps/48/konversation.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/data/icons/test-theme/index.theme <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.h <span style="color: grey">(9fd3063)</span></li>
<li>autotests/iconitemtest.cpp <span style="color: grey">(ea98c9d)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(c65a9a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127201/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3408386335214584800==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic