[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)
From: "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date: 2016-02-29 2:22:13
Message-ID: 20160229022213.12079.42061 () mimi ! kde ! org
[Download RAW message or body]
--===============5923192990695079118==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > Nice!
> >
> > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and the \
> > popup is always white. Not much we can do here :(
> > I gave the applet a try and there's a couple of issues:
> >
> > - It seems Plasma doesn't properly setup the widget. If I drag it to the desktop \
> > it works but if I double click to add it it says "Error loading widget: Package \
> > does not exist", same when I add it to system tray.
> > - It doesn't properly load a new weather station, the busy indicator just spins \
> > forever; I need to restart Plasma for the weather to show up.
> > - The popup size when placed in a panel and the default size on the desktop is \
> > way too small
> > - The plasmoid is just empty when it is not configured; Plasmoid has a \
> > configurationRequired property which shows a "You need to configure this thing \
> > first [Configure]"
> > - It sometimes seems to forget the weather station when I open settings and when \
> > I then save settings the applet is blank again
> > - Sometimes it doesn't find any weather stations in the search
> > - The tooltip subtext is blank (but not empty, ie. I get an additional empty \
> > line)
> > - The strip with the temperatures needs to be taller, text barely fits in there. \
> > The weather icons also leak outside the strip but this looks like it might be \
> > intended.
> > It also looks like we need some Breeze weather icons :)
>
> Friedrich W. H. Kossebau wrote:
> Thanks a lot for your detailed review and testing, very appreciated!
>
> > if I double click to add it it says "Error loading widget: Package does not \
> > exist", same when I add it to system tray.
>
> Confirmed. Same issue here also with the comic applet. Perhaps something related to \
> being cpp-backed applets? Shall I file a bug so it can be tracked? At least I \
> assume nothing I can fix in the applet itself.
> > It doesn't properly load a new weather station, the busy indicator just spins \
> > forever; I need to restart Plasma for the weather to show up.
>
> Can reproduce, at least the busy indicator on the compact applet, still \
> investigating how the busy flag is set to wrong value. But here the config itself \
> works, the new weather station is used and data shown as expected. Just the busy \
> indicator stays. So still ISSUE.
>
> > The popup size when placed in a panel and the default size on the desktop is way \
> > too small
>
> Yes. Seems there are binding issues with the width & height values, I am still lost \
> what the Plasma5 approach is and need to investigate more. So still ISSUE.
>
> > The plasmoid is just empty when it is not configured; Plasmoid has a \
> > configurationRequired property which shows a "You need to configure this thing \
> > first [Configure]"
>
> The C++-code (for the base class) uses `Applet::setConfigurationRequired(false)`, \
> is that no longer working or not enough?
> > It sometimes seems to forget the weather station when I open settings and when I \
> > then save settings the applet is blank again
>
> I have not seen that, any chance you can tell how to reproduce?
>
> > Sometimes it doesn't find any weather stations in the search
>
> Wetter.com might sometimes tack a few secs, though usually replies instantly. The \
> service behind "noaa" data engine though seems to Needs perhaps inspection and \
> fixing in the weather dataengines (in plasma-workspace/dataengines/weather/. The \
> code/logic in the weather applet I mainly moved around (from old WeatherConfig \
> class to LocationListModel), still possible I messed something up.
> > The tooltip subtext is blank (but not empty, ie. I get an additional empty line)
>
> Fixed, catching the case where "%1 %2" is filled with empty strings due to no data.
>
> > The strip with the temperatures needs to be taller, text barely fits in there. \
> > The weather icons also leak outside the strip but this looks like it might be \
> > intended.
>
> I think it is by design. The Plasma4 version looked the same. And I do not want to \
> mess around with the design, that I happily leave to VDG once the applet itself is \
> ported and works in a first version :)
> Kai Uwe Broulik wrote:
> > Shall I file a bug so it can be tracked?
>
> Yes, please, indeed looks like a bug with native applets, perhaps the setup applet \
> scripts or so aren't run properly. Marco?
> > is that no longer working or not enough?
>
> Can you try from QML? Plasmoid.configurationRequired: true; perhaps it was \
> broken/never ported to the new QML containment as we haven't had a plasmoid so far \
> in Plasma 5 that actually used this; if it doesn't, file a bug, please.
> > Seems there are binding issues with the width & height values
>
> Try with Layout.minimumWidth and/or preferredWidth.
>
> > I think it is by design.
>
> For the weather icons that's fine but I have a high dpi screen and thus large fonts \
> and so the temperature barely fits into the strip whereas on your screenshot it \
> looks fine. Try setting the height to theme.mSize(yourlabel.font) (or so)
> > Shall I file a bug so it can be tracked?
> Yes, please
Done, https://bugs.kde.org/show_bug.cgi?id=359902
> Can you try from QML? Plasmoid.configurationRequired: true;
Results in applet not being loaded due to error on loading QML file: Cannot assign to \
non-existent property "configurationRequired"
Also no real hits on \
https://lxr.kde.org/search?_filestring=&_string=configurationRequired
Filed as minor bug in https://bugs.kde.org/show_bug.cgi?id=359906
> Try with Layout.minimumWidth and/or preferredWidth.
Tried with that, seems things are working slightly better now.
> Try setting the height to theme.mSize(yourlabel.font) (or so)
Tried something with that, please test.
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/DetailsView.qml, line 41
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445617#file445617line41>
> >
> > visible: !!elementId ?
>
> Friedrich W. H. Kossebau wrote:
> If that shortcut is okay with Plasma JavaScript pattern policy, okay. Picked up.
>
> Kai Uwe Broulik wrote:
> I don't think we have a policy for this, you could also do elementId !== "" but I \
> was more referring to not asking for the rowData.icon property again if you use it \
> for the icon already, makes it clearer imho but that's up to you :)
I seem to miss what you mean here :) What exactly is the `elementId` here and how \
would that work?
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/configGeneral.qml, line 34
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445623#file445623line34>
> >
> > What's the rationale for not using plasmoid.configuration?
Reason is that some defaults are based on the QLocale().measurementSystem with the \
existing code (e.g. Celsius vs. Fahrrenheit), and I could not see a way to do this \
with main.xml. Happy to change to main.xml as an improvement later, if possible.
As also noted in the email \
https://mail.kde.org/pipermail/plasma-devel/2016-February/049824.html (which might \
have been missed due to all ml traffic).
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/configGeneral.qml, line 48
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445623#file445623line48>
> >
> > I think abusing the ComboBox for the results is a terrible idea and it always \
> > was. Can we do better than that, like a search input and then a TableView of \
> > results below or something like that?
>
> Friedrich W. H. Kossebau wrote:
> Agree that the approach is rather "interesting" and should be revisited by UI \
> experts. As said, for now concentrated on porting the existing applet and would \
> like to postpone this to after the applet is ported as it is. Okay to drop this for \
> this review?
> Kai Uwe Broulik wrote:
> Ok, sure, but we should make sure we don't forget it. :) I think that would also \
> alleviate the feeling of "It's not loading anything" if we had a BusyIndicator in \
> there.
There is a BusyIndicator now next to the search button (following the old UI), for \
the placeholder "somespinningwheel". So that part should be covered (well, just that \
noaa dataengine never seems to return results currently, so the BusyIndicator spins \
and spins...)
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/WeatherListView.qml, line 40
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445622#file445622line40>
> >
> > Qt.color(theme.textColor.r, theme.textColor.g, theme.textColor.b, youralphahere)
Picked up (you surely meant Qt.rgba())
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/FiveDaysView.qml, line 62
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445618#file445618line62>
> >
> > Again, PlasmaComponents.Label
>
> Friedrich W. H. Kossebau wrote:
> Done. But this shows a strange bug on initial layout, the first item in the row is \
> lower (disappears if e.g. the size of the applet is changed). Marked as TODO in the \
> code for now.
> Kai Uwe Broulik wrote:
> The PlasmaComponents.Label sets a default height of "letter M height * 1.6" or so \
> which might cause this, try resetting this to the defaults:
> height: undefined
That seems to work. Added with a note.
> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/contents/ui/main.qml, lines 27-31
> > <https://git.reviewboard.kde.org/r/127193/diff/1/?file=445624#file445624line27>
> >
> > Base those sizes on units.gridUnit * n
>
> Friedrich W. H. Kossebau wrote:
> Any rule of thumbs I could use mapping the old pixel values to their `n` \
> counterparts? Also wondering why one has to explicitely set min size, can't that be \
> calculated from the items and layout?
> Kai Uwe Broulik wrote:
> The "problem" is that the fullRepresentation is created on demand (if you expand \
> the popup for the first time or it becomes large enough), so you cannot really \
> access it from outside and/or know that in advance. There's a also a \
> switchWidth/height property you can use to tell it when to collapse to \
> compactRepresentation.
I still need to grasp more things obviously to understand when things are \
evaluated/processed and when not, given the Layout property and its properties are \
only defined on the fullRepresentation Item (QQ beginner still :) ). In any case, \
switched code to base min/preferred sizes on units.gridUnit, so this issue fixed.
- Friedrich W. H.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127193/#review92824
-----------------------------------------------------------
On Feb. 28, 2016, 8:11 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127193/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 8:11 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> So the weather applet in branch kossebau/weatherapplet works okayish now here, both \
> on panel and on containment: https://share.kde.org/index.php/s/MxwDYtmRw9TtQ8X
>
> This revival is done as minimal porting, after more considerations I for now kept \
> libplasmaweather as it is where possible (also because I use classes from the lib \
> in the QML plugin and in the applet, so some shared unit is needed). I propose to \
> do further modernizing & refactoring of the applet code only once it works again \
> completely and can be part of 5.6 release.
> Please help with a quick review. And also with a few issues that still need to be \
> solved for a perfect solution. Where I need your, the experts', help, please read \
> on.
> Layout:
> `configGeneral.qml` needs larger minimal sizes of the input fields. How can this be \
> done? I am lost with the QQ2 layout approach for now.
> Size of applet in fullRepresentation mode when expanded from panel:
> while the expanded applet had some kind of sane size all the time I was playing \
> (cmp. the screenshot), at one point the size of the expanded representation only \
> turned into some unusable 16x16 or similar size. For existing applets and new ones. \
>
> Q: Is this ported correctly (a hack I found elsewhere), or is there a better way \
> meanwhile? ```
> q->setBusy(false);
> ```
> to
> ```
> QObject *graphicObject = q->property("_plasma_graphicObject").value<QObject *>();
> if (graphicObject) {
> graphicObject->setProperty("busy", false);
> }
> ```
>
> Q: `Plasma::Applet::showMessage()` can be ported to what?
>
> Q: `DataEngine::query()` should be ported to? Similar code is unported also in the \
> weather/ions/ion_noaa dataengine in plasma-workspace.
> ```
> Plasma::DataEngine::Data data = timeEngine->query(
> QString(QLatin1String( "Local|Solar|Latitude=%1|Longitude=%2" \
> )).arg(latitude).arg(longitude)); bool day = data[QLatin1String( "Corrected \
> Elevation" )].toDouble() > 0.0); ```
>
>
> Diffs
> -----
>
> CMakeLists.txt 5568251
> applets/CMakeLists.txt bd3ea48
> applets/weather/CMakeLists.txt 354b6ee
> applets/weather/package/contents/config/config.qml PRE-CREATION
> applets/weather/package/contents/ui/DetailsView.qml bbcdd15
> applets/weather/package/contents/ui/FiveDaysView.qml a39f334
> applets/weather/package/contents/ui/Notice.qml d38c108
> applets/weather/package/contents/ui/NoticesView.qml 16923c4
> applets/weather/package/contents/ui/TopPanel.qml af57f45
> applets/weather/package/contents/ui/WeatherListView.qml b29099f
> applets/weather/package/contents/ui/configGeneral.qml PRE-CREATION
> applets/weather/package/contents/ui/main.qml c501ab3
> applets/weather/package/metadata.desktop 79646c2
> applets/weather/plasma-applet-weather.desktop aca6da2
> applets/weather/plugin/abstractunitlistmodel.h PRE-CREATION
> applets/weather/plugin/abstractunitlistmodel.cpp PRE-CREATION
> applets/weather/plugin/locationlistmodel.h PRE-CREATION
> applets/weather/plugin/locationlistmodel.cpp PRE-CREATION
> applets/weather/plugin/plugin.h PRE-CREATION
> applets/weather/plugin/plugin.cpp PRE-CREATION
> applets/weather/plugin/qmldir PRE-CREATION
> applets/weather/weatherapplet.h c4b376b
> applets/weather/weatherapplet.cpp 60f882a
> libs/CMakeLists.txt bd71119
> libs/plasmaweather/CMakeLists.txt a9faa7b
> libs/plasmaweather/plasmaweather.knsrc 8525f20
> libs/plasmaweather/plasmaweather_export.h 691db23
> libs/plasmaweather/weatherconfig.h 9b3c2d7
> libs/plasmaweather/weatherconfig.cpp 1ec0b42
> libs/plasmaweather/weatherconfig.ui f285fff
> libs/plasmaweather/weatheri18ncatalog.h 0122378
> libs/plasmaweather/weatheri18ncatalog.cpp 1868352
> libs/plasmaweather/weatherlocation.h 004d788
> libs/plasmaweather/weatherlocation.cpp 1d275ea
> libs/plasmaweather/weatherpopupapplet.h ce95a5a
> libs/plasmaweather/weatherpopupapplet.cpp 4533619
> libs/plasmaweather/weathervalidator.h eb33558
> libs/plasmaweather/weathervalidator.cpp 4d016e2
>
> Diff: https://git.reviewboard.kde.org/r/127193/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
--===============5923192990695079118==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127193/">https://git.reviewboard.kde.org/r/127193/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nice!</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding the ComboBox \
issues, we know, it's horrible, sizing is broken and the popup is always white. Not \
much we can do here :(</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I gave the applet a try and there's a \
couple of issues:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">It seems Plasma doesn't \
properly setup the widget. If I drag it to the desktop it works but if I double click \
to add it it says "Error loading widget: Package does not exist", same when I add it \
to system tray.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">It doesn't properly load a new weather \
station, the busy indicator just spins forever; I need to restart Plasma for the \
weather to show up.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">The popup size when placed in a panel \
and the default size on the desktop is way too small</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The \
plasmoid is just empty when it is not configured; Plasmoid has a \
configurationRequired property which shows a "You need to configure this thing first \
[Configure]"</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">It sometimes seems to forget the weather \
station when I open settings and when I then save settings the applet is blank \
again</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Sometimes it doesn't find any weather stations in the \
search</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">The tooltip subtext is blank (but not empty, ie. I get \
an additional empty line)</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">The strip with the temperatures needs to \
be taller, text barely fits in there. The weather icons also leak outside the strip \
but this looks like it might be intended.</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It also looks like we need some Breeze weather icons \
:)</p></pre> </blockquote>
<p>On February 28th, 2016, 8:08 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks a lot for your detailed review and testing, very appreciated!</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">if I double click to add it it says "Error loading widget: Package does not \
exist", same when I add it to system tray.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Confirmed. Same issue here also with the comic applet. \
Perhaps something related to being cpp-backed applets? Shall I file a bug so it can \
be tracked? At least I assume nothing I can fix in the applet itself.</p> <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It doesn't properly load a new weather station, the busy indicator just \
spins forever; I need to restart Plasma for the weather to show up.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can reproduce, at least the busy indicator on the \
compact applet, still investigating how the busy flag is set to wrong value. But here \
the config itself works, the new weather station is used and data shown as expected. \
Just the busy indicator stays. So still ISSUE.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The popup size when placed in a panel and the default size on the desktop \
is way too small</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes. Seems there are binding issues with the width \
& height values, I am still lost what the Plasma5 approach is and need to \
investigate more. So still ISSUE.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The plasmoid is just empty when it is not configured; Plasmoid has a \
configurationRequired property which shows a "You need to configure this thing first \
[Configure]"</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The C++-code (for the base class) uses <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Applet::setConfigurationRequired(false)</code>, is that no \
longer working or not enough?</p> <blockquote style="text-rendering: inherit;padding: \
0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 \
0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It sometimes seems to forget the \
weather station when I open settings and when I then save settings the applet is \
blank again</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have not seen that, any chance you can tell how to \
reproduce?</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sometimes it doesn't find any weather stations in the \
search</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Wetter.com might sometimes tack a few secs, though \
usually replies instantly. The service behind "noaa" data engine though seems to \
Needs perhaps inspection and fixing in the weather dataengines (in \
plasma-workspace/dataengines/weather/. The code/logic in the weather applet I mainly \
moved around (from old WeatherConfig class to LocationListModel), still possible I \
messed something up.</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The tooltip subtext is blank (but not empty, ie. I get \
an additional empty line)</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixed, catching the case where "%1 %2" is filled with \
empty strings due to no data.</p> <blockquote style="text-rendering: inherit;padding: \
0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 \
0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The strip with the temperatures needs \
to be taller, text barely fits in there. The weather icons also leak outside the \
strip but this looks like it might be intended.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think it is by design. The Plasma4 version looked \
the same. And I do not want to mess around with the design, that I happily leave to \
VDG once the applet itself is ported and works in a first version :)</p></pre> \
</blockquote>
<p>On February 28th, 2016, 8:19 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shall I file a bug so it can be tracked?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, please, indeed looks like a bug with native \
applets, perhaps the setup applet scripts or so aren't run properly. Marco?</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">is that no longer working or not enough?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you try from QML? Plasmoid.configurationRequired: \
true; perhaps it was broken/never ported to the new QML containment as we haven't had \
a plasmoid so far in Plasma 5 that actually used this; if it doesn't, file a bug, \
please.</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems there are binding issues with the width & \
height values</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Try with Layout.minimumWidth and/or \
preferredWidth.</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think it is by design.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For the weather icons that's fine but I have a high \
dpi screen and thus large fonts and so the temperature barely fits into the strip \
whereas on your screenshot it looks fine. Try setting the height to \
theme.mSize(yourlabel.font) (or so)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shall I file a bug so it can be tracked?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, please</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Done, https://bugs.kde.org/show_bug.cgi?id=359902</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Can you try from QML? Plasmoid.configurationRequired: true; </p> \
</blockquote> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Results in applet not being loaded due to error on \
loading QML file: Cannot assign to non-existent property "configurationRequired"</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also no real hits on \
https://lxr.kde.org/search?_filestring=&_string=configurationRequired</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Filed as minor bug in https://bugs.kde.org/show_bug.cgi?id=359906</p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Try with Layout.minimumWidth and/or preferredWidth.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tried with that, seems things are working slightly \
better now.</p> <blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Try setting the height to theme.mSize(yourlabel.font) \
(or so)</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tried something with that, please test.</p></pre> <br \
/>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445617#file445617line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/DetailsView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">40</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">visible:</span> <span class="nx">rowData</span><span \
class="p">.</span><span class="nx">icon</span><span class="p">.</span><span \
class="nx">length</span> <span class="o">></span> <span \
class="mi">0</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">41</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">visible:</span> \
<span class="nx">rowData</span><span class="p">.</span><span \
class="nx">icon</span><span class="p">.</span><span class="nx">length</span> <span \
class="o">></span> <span class="mi">0</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">visible: !!elementId ?</p></pre> </blockquote>
<p>On February 28th, 2016, 8:08 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
that shortcut is okay with Plasma JavaScript pattern policy, okay. Picked \
up.</p></pre> </blockquote>
<p>On February 28th, 2016, 8:19 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think we have a policy for this, you could also do elementId !== "" but I was \
more referring to not asking for the rowData.icon property again if you use it for \
the icon already, makes it clearer imho but that's up to you :)</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I seem to miss what you mean here :) What exactly is the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">elementId</code> here and how would that work?</p></pre> <br \
/>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445618#file445618line62" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/FiveDaysView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">61</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">Text</span> <span class="p">{</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">62</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">Text</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Again, PlasmaComponents.Label</p></pre> </blockquote>
<p>On February 28th, 2016, 8:08 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done. \
But this shows a strange bug on initial layout, the first item in the row is lower \
(disappears if e.g. the size of the applet is changed). Marked as TODO in the code \
for now.</p></pre> </blockquote>
<p>On February 28th, 2016, 8:19 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
PlasmaComponents.Label sets a default height of "letter M height * 1.6" or so which \
might cause this, try resetting this to the defaults:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">height: undefined</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That seems to work. Added with a note.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445622#file445622line40" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/WeatherListView.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">39</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">color:</span> <span class="nx">Utils</span><span class="p">.</span><span \
class="nx">setAlphaF</span><span class="p">(</span><span class="nx">theme</span><span \
class="p">.</span><span class="nx">textColor</span><span class="p">,</span> <span \
class="p">((</span><span class="nx">index</span><span class="o">+</span><span \
class="mi">1</span><span class="p">)</span><span class="o">/</span><span \
class="nx">repeater</span><span class="p">.</span><span class="nx">count</span><span \
class="p">)</span><span class="o">*</span><span class="mf">0.3</span><span \
class="p">);</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">40</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">color:</span> <span \
class="nx">Utils</span><span class="p">.</span><span class="nx">setAlphaF</span><span \
class="p">(</span><span class="nx">theme</span><span class="p">.</span><span \
class="nx">textColor</span><span class="p">,</span> <span class="p">((</span><span \
class="nx">index</span><span class="o">+</span><span class="mi">1</span><span \
class="p">)</span><span class="o">/</span><span class="nx">repeater</span><span \
class="p">.</span><span class="nx">count</span><span class="p">)</span><span \
class="o">*</span><span class="mf">0.3</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Qt.color(theme.textColor.r, theme.textColor.g, theme.textColor.b, \
youralphahere)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Picked up (you surely meant Qt.rgba())</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445623#file445623line34" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/configGeneral.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">34</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">plasmoid</span><span class="p">.</span><span \
class="nx">nativeInterface</span><span class="p">.</span><span \
class="nx">temperatureUnitId</span> <span class="o">=</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What's the rationale for not using plasmoid.configuration?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Reason is that some defaults are based on the QLocale().measurementSystem \
with the existing code (e.g. Celsius vs. Fahrrenheit), and I could not see a way to \
do this with main.xml. Happy to change to main.xml as an improvement later, if \
possible.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As also noted in the email \
https://mail.kde.org/pipermail/plasma-devel/2016-February/049824.html (which might \
have been missed due to all ml traffic).</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445623#file445623line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/configGeneral.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">locationListModel</span><span class="p">.</span><span \
class="nx">searchLocations</span><span class="p">(</span><span \
class="nx">locationComboBox</span><span class="p">.</span><span \
class="nx">editText</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think abusing the ComboBox for the results is a terrible idea and it always was. Can \
we do better than that, like a search input and then a TableView of results below or \
something like that?</p></pre> </blockquote>
<p>On February 28th, 2016, 8:08 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Agree \
that the approach is rather "interesting" and should be revisited by UI experts. As \
said, for now concentrated on porting the existing applet and would like to postpone \
this to after the applet is ported as it is. Okay to drop this for this \
review?</p></pre> </blockquote>
<p>On February 28th, 2016, 8:19 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
sure, but we should make sure we don't forget it. :) I think that would also \
alleviate the feeling of "It's not loading anything" if we had a BusyIndicator in \
there.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There is a BusyIndicator now next to the search button (following the old \
UI), for the placeholder "somespinningwheel". So that part should be covered (well, \
just that noaa dataengine never seems to return results currently, so the \
BusyIndicator spins and spins...)</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2016, 10:27 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127193/diff/1/?file=445624#file445624line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/contents/ui/main.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">25</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">implicitWidth:</span> <span class="mi">250</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">implicitWidth:</span> <span class="mi">250</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">26</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">implicitHeight:</span> <span class="mi">350</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">implicitHeight:</span> <span class="mi">350</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">27</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">28</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">minimumWidth:</span> <span class="mi">373</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">minimumWidth:</span> <span class="mi">373</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">29</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">minimumHeight:</span> <span class="mi">272</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">property</span> <span class="kr">int</span> <span \
class="k">minimumHeight:</span> <span class="mi">272</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Base \
those sizes on units.gridUnit * n</p></pre> </blockquote>
<p>On February 28th, 2016, 8:08 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
rule of thumbs I could use mapping the old pixel values to their <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">n</code> counterparts? Also wondering why one has to \
explicitely set min size, can't that be calculated from the items and \
layout?</p></pre> </blockquote>
<p>On February 28th, 2016, 8:19 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
"problem" is that the fullRepresentation is created on demand (if you expand the \
popup for the first time or it becomes large enough), so you cannot really access it \
from outside and/or know that in advance. There's a also a switchWidth/height \
property you can use to tell it when to collapse to compactRepresentation.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I still need to grasp more things obviously to understand when things are \
evaluated/processed and when not, given the Layout property and its properties are \
only defined on the fullRepresentation Item (QQ beginner still :) ). In any case, \
switched code to base min/preferred sizes on units.gridUnit, so this issue \
fixed.</p></pre> <br />
<p>- Friedrich W. H.</p>
<br />
<p>On February 28th, 2016, 8:11 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2016, 8:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So the weather applet in branch kossebau/weatherapplet \
works okayish now here, both on panel and on containment: \
https://share.kde.org/index.php/s/MxwDYtmRw9TtQ8X</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
revival is done as minimal porting, after more considerations I for now kept \
libplasmaweather as it is where possible (also because I use classes from the lib in \
the QML plugin and in the applet, so some shared unit is needed). I propose to do \
further modernizing & refactoring of the applet code only once it works again \
completely and can be part of 5.6 release.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please help with a \
quick review. And also with a few issues that still need to be solved for a perfect \
solution. Where I need your, the experts', help, please read on.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Layout: <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">configGeneral.qml</code> needs \
larger minimal sizes of the input fields. How can this be done? I am lost with the \
QQ2 layout approach for now.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Size of applet in fullRepresentation \
mode when expanded from panel: while the expanded applet had some kind of sane size \
all the time I was playing (cmp. the screenshot), at one point the size of the \
expanded representation only turned into some unusable 16x16 or similar size. For \
existing applets and new ones.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Q: Is this ported \
correctly (a hack I found elsewhere), or is there a better way meanwhile?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;"><div class="codehilite" style="background: #f8f8f8"><pre \
style="line-height: 125%"> q->setBusy(false); </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">to</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"> QObject *graphicObject \
= q->property("_plasma_graphicObject").value<QObject *>(); if \
(graphicObject) { graphicObject->setProperty("busy", false);
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Q: <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Plasma::Applet::showMessage()</code> can be ported to what?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Q: <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">DataEngine::query()</code> \
should be ported to? Similar code is unported also in the weather/ions/ion_noaa \
dataengine in plasma-workspace.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"> \
Plasma::DataEngine::Data data = timeEngine->query(
QString(QLatin1String( \
"Local|Solar|Latitude=%1|Longitude=%2" \
)).arg(latitude).arg(longitude));
bool day = data[QLatin1String( "Corrected Elevation" )].toDouble() \
> 0.0); </pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5568251)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(bd3ea48)</span></li>
<li>applets/weather/CMakeLists.txt <span style="color: grey">(354b6ee)</span></li>
<li>applets/weather/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/DetailsView.qml <span style="color: \
grey">(bbcdd15)</span></li>
<li>applets/weather/package/contents/ui/FiveDaysView.qml <span style="color: \
grey">(a39f334)</span></li>
<li>applets/weather/package/contents/ui/Notice.qml <span style="color: \
grey">(d38c108)</span></li>
<li>applets/weather/package/contents/ui/NoticesView.qml <span style="color: \
grey">(16923c4)</span></li>
<li>applets/weather/package/contents/ui/TopPanel.qml <span style="color: \
grey">(af57f45)</span></li>
<li>applets/weather/package/contents/ui/WeatherListView.qml <span style="color: \
grey">(b29099f)</span></li>
<li>applets/weather/package/contents/ui/configGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/main.qml <span style="color: \
grey">(c501ab3)</span></li>
<li>applets/weather/package/metadata.desktop <span style="color: \
grey">(79646c2)</span></li>
<li>applets/weather/plasma-applet-weather.desktop <span style="color: \
grey">(aca6da2)</span></li>
<li>applets/weather/plugin/abstractunitlistmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/abstractunitlistmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/locationlistmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/locationlistmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/plugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/plugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/plugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/weatherapplet.h <span style="color: grey">(c4b376b)</span></li>
<li>applets/weather/weatherapplet.cpp <span style="color: \
grey">(60f882a)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(bd71119)</span></li>
<li>libs/plasmaweather/CMakeLists.txt <span style="color: \
grey">(a9faa7b)</span></li>
<li>libs/plasmaweather/plasmaweather.knsrc <span style="color: \
grey">(8525f20)</span></li>
<li>libs/plasmaweather/plasmaweather_export.h <span style="color: \
grey">(691db23)</span></li>
<li>libs/plasmaweather/weatherconfig.h <span style="color: \
grey">(9b3c2d7)</span></li>
<li>libs/plasmaweather/weatherconfig.cpp <span style="color: \
grey">(1ec0b42)</span></li>
<li>libs/plasmaweather/weatherconfig.ui <span style="color: \
grey">(f285fff)</span></li>
<li>libs/plasmaweather/weatheri18ncatalog.h <span style="color: \
grey">(0122378)</span></li>
<li>libs/plasmaweather/weatheri18ncatalog.cpp <span style="color: \
grey">(1868352)</span></li>
<li>libs/plasmaweather/weatherlocation.h <span style="color: \
grey">(004d788)</span></li>
<li>libs/plasmaweather/weatherlocation.cpp <span style="color: \
grey">(1d275ea)</span></li>
<li>libs/plasmaweather/weatherpopupapplet.h <span style="color: \
grey">(ce95a5a)</span></li>
<li>libs/plasmaweather/weatherpopupapplet.cpp <span style="color: \
grey">(4533619)</span></li>
<li>libs/plasmaweather/weathervalidator.h <span style="color: \
grey">(eb33558)</span></li>
<li>libs/plasmaweather/weathervalidator.cpp <span style="color: \
grey">(4d016e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127193/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5923192990695079118==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic