[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework
From: Sergey Popov <sergobot () protonmail ! com>
Date: 2016-02-28 23:22:13
Message-ID: 20160228232213.12079.40649 () mimi ! kde ! org
[Download RAW message or body]
--===============7726225339212032843==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126672/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 11:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
Changes
-------
Submitted with commit 9f625326745369b289952b3d83a2f3478cca4748 by Aleix Pol to branch \
master.
Repository: plasma-framework
Description
-------
Fix almost all the Clazy warnings in plasma-framework.
Related GCI-2015 task: \
[https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks/6272625345036288/)
Diffs
-----
autotests/coronatest.cpp 378a4b7
autotests/dialogqmltest.cpp 618e64d
autotests/fallbackpackagetest.cpp 91bc6e9
autotests/packagestructuretest.cpp 67cdb4f
autotests/pluginloadertest.cpp 868d5f8
autotests/sortfiltermodeltest.cpp 6ee0e35
autotests/storagetest.cpp 8a7dbd0
src/declarativeimports/calendar/calendar.cpp 5515550
src/declarativeimports/calendar/daysmodel.cpp 0f81b5a
src/declarativeimports/core/corebindingsplugin.cpp adfdc29
src/declarativeimports/core/datamodel.cpp 4449f30
src/declarativeimports/core/datasource.cpp 4fe5dc5
src/declarativeimports/core/tooltip.cpp a5e223b
src/declarativeimports/core/tooltipdialog.cpp 6c3712e
src/declarativeimports/core/units.cpp 1798727
src/declarativeimports/core/windowthumbnail.cpp 21e655e
src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 9e924b3
src/declarativeimports/plasmacomponents/qmenuitem.cpp 287e9b3
src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp \
1a25f06 src/plasma/applet.cpp 4ce2d28
src/plasma/containment.cpp 0beb196
src/plasma/containmentactions.cpp f42807f
src/plasma/corona.cpp bae9244
src/plasma/datacontainer.cpp 396bc6d
src/plasma/dataengine.cpp dd56807
src/plasma/dataengineconsumer.cpp 7c9b5f9
src/plasma/framesvg.cpp 81187dc
src/plasma/package.cpp 09f36f3
src/plasma/packagestructure.cpp 09ea698
src/plasma/pluginloader.cpp d7c49f2
src/plasma/private/applet_p.cpp 949c92e
src/plasma/private/associatedapplicationmanager.cpp e1620e9
src/plasma/private/componentinstaller.cpp 8fbef24
src/plasma/private/containment_p.cpp 09ed2cd
src/plasma/private/dataenginemanager.cpp 7862171
src/plasma/private/packages.cpp 1edd55a
src/plasma/private/service_p.h 8a48487
src/plasma/private/storage.cpp bc6992e
src/plasma/private/storagethread.cpp 91b490b
src/plasma/private/svg_p.h 1d1000d
src/plasma/private/theme_p.cpp 18419bb
src/plasma/private/timetracker.cpp cdfe94b
src/plasma/scripting/scriptengine.cpp b9f43fe
src/plasma/service.cpp d603cf2
src/plasma/svg.cpp 28abd00
src/plasma/theme.cpp e9420e6
src/plasmapkg/main.cpp 336b14e
src/plasmapkg/plasmapkg.cpp 4626323
src/plasmaquick/appletquickitem.cpp ec2ed24
src/plasmaquick/configmodel.cpp df537c1
src/plasmaquick/configview.cpp c4ab518
src/plasmaquick/dialog.cpp 8f4ee57
src/plasmaquick/dialogshadows.cpp db408ae
src/plasmaquick/dialogshadows_p.h 7e17c12
src/plasmaquick/packageurlinterceptor.cpp 5e349d2
src/plasmaquick/private/packages.h aa08b11
src/plasmaquick/private/packages.cpp 5275848
src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a
src/scriptengines/qml/plasmoid/containmentinterface.cpp 31285a2
src/scriptengines/qml/plasmoid/declarativeappletscript.cpp b15695b
src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ecd62b
tests/dpi/main.cpp 6767b2d
tests/kplugins/main.cpp 421e3fb
tests/kplugins/plugintest.h a99701a
tests/kplugins/plugintest.cpp 3d98dec
tests/testengine/testengine.cpp 76947c3
Diff: https://git.reviewboard.kde.org/r/126672/diff/
Testing
-------
Tests passed
Thanks,
Sergey Popov
--===============7726225339212032843==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126672/">https://git.reviewboard.kde.org/r/126672/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.</div>
<div>By Sergey Popov.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2016, 11:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9f625326745369b289952b3d83a2f3478cca4748 by Aleix \
Pol to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix almost all the Clazy warnings in \
plasma-framework.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Related GCI-2015 task: <a \
href="https://codein.withgoogle.com/tasks/6272625345036288/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">https://codein.withgoogle.com/tasks/6272625345036288/</a></p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests passed</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/coronatest.cpp <span style="color: grey">(378a4b7)</span></li>
<li>autotests/dialogqmltest.cpp <span style="color: grey">(618e64d)</span></li>
<li>autotests/fallbackpackagetest.cpp <span style="color: \
grey">(91bc6e9)</span></li>
<li>autotests/packagestructuretest.cpp <span style="color: \
grey">(67cdb4f)</span></li>
<li>autotests/pluginloadertest.cpp <span style="color: grey">(868d5f8)</span></li>
<li>autotests/sortfiltermodeltest.cpp <span style="color: \
grey">(6ee0e35)</span></li>
<li>autotests/storagetest.cpp <span style="color: grey">(8a7dbd0)</span></li>
<li>src/declarativeimports/calendar/calendar.cpp <span style="color: \
grey">(5515550)</span></li>
<li>src/declarativeimports/calendar/daysmodel.cpp <span style="color: \
grey">(0f81b5a)</span></li>
<li>src/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(adfdc29)</span></li>
<li>src/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(4449f30)</span></li>
<li>src/declarativeimports/core/datasource.cpp <span style="color: \
grey">(4fe5dc5)</span></li>
<li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(a5e223b)</span></li>
<li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: \
grey">(6c3712e)</span></li>
<li>src/declarativeimports/core/units.cpp <span style="color: \
grey">(1798727)</span></li>
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: \
grey">(21e655e)</span></li>
<li>src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp <span \
style="color: grey">(9e924b3)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenuitem.cpp <span style="color: \
grey">(287e9b3)</span></li>
<li>src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp \
<span style="color: grey">(1a25f06)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(4ce2d28)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(0beb196)</span></li>
<li>src/plasma/containmentactions.cpp <span style="color: \
grey">(f42807f)</span></li>
<li>src/plasma/corona.cpp <span style="color: grey">(bae9244)</span></li>
<li>src/plasma/datacontainer.cpp <span style="color: grey">(396bc6d)</span></li>
<li>src/plasma/dataengine.cpp <span style="color: grey">(dd56807)</span></li>
<li>src/plasma/dataengineconsumer.cpp <span style="color: \
grey">(7c9b5f9)</span></li>
<li>src/plasma/framesvg.cpp <span style="color: grey">(81187dc)</span></li>
<li>src/plasma/package.cpp <span style="color: grey">(09f36f3)</span></li>
<li>src/plasma/packagestructure.cpp <span style="color: grey">(09ea698)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(d7c49f2)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(949c92e)</span></li>
<li>src/plasma/private/associatedapplicationmanager.cpp <span style="color: \
grey">(e1620e9)</span></li>
<li>src/plasma/private/componentinstaller.cpp <span style="color: \
grey">(8fbef24)</span></li>
<li>src/plasma/private/containment_p.cpp <span style="color: \
grey">(09ed2cd)</span></li>
<li>src/plasma/private/dataenginemanager.cpp <span style="color: \
grey">(7862171)</span></li>
<li>src/plasma/private/packages.cpp <span style="color: grey">(1edd55a)</span></li>
<li>src/plasma/private/service_p.h <span style="color: grey">(8a48487)</span></li>
<li>src/plasma/private/storage.cpp <span style="color: grey">(bc6992e)</span></li>
<li>src/plasma/private/storagethread.cpp <span style="color: \
grey">(91b490b)</span></li>
<li>src/plasma/private/svg_p.h <span style="color: grey">(1d1000d)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(18419bb)</span></li>
<li>src/plasma/private/timetracker.cpp <span style="color: \
grey">(cdfe94b)</span></li>
<li>src/plasma/scripting/scriptengine.cpp <span style="color: \
grey">(b9f43fe)</span></li>
<li>src/plasma/service.cpp <span style="color: grey">(d603cf2)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(28abd00)</span></li>
<li>src/plasma/theme.cpp <span style="color: grey">(e9420e6)</span></li>
<li>src/plasmapkg/main.cpp <span style="color: grey">(336b14e)</span></li>
<li>src/plasmapkg/plasmapkg.cpp <span style="color: grey">(4626323)</span></li>
<li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(ec2ed24)</span></li>
<li>src/plasmaquick/configmodel.cpp <span style="color: grey">(df537c1)</span></li>
<li>src/plasmaquick/configview.cpp <span style="color: grey">(c4ab518)</span></li>
<li>src/plasmaquick/dialog.cpp <span style="color: grey">(8f4ee57)</span></li>
<li>src/plasmaquick/dialogshadows.cpp <span style="color: \
grey">(db408ae)</span></li>
<li>src/plasmaquick/dialogshadows_p.h <span style="color: \
grey">(7e17c12)</span></li>
<li>src/plasmaquick/packageurlinterceptor.cpp <span style="color: \
grey">(5e349d2)</span></li>
<li>src/plasmaquick/private/packages.h <span style="color: \
grey">(aa08b11)</span></li>
<li>src/plasmaquick/private/packages.cpp <span style="color: \
grey">(5275848)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: \
grey">(8e4979a)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: \
grey">(31285a2)</span></li>
<li>src/scriptengines/qml/plasmoid/declarativeappletscript.cpp <span style="color: \
grey">(b15695b)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: \
grey">(9ecd62b)</span></li>
<li>tests/dpi/main.cpp <span style="color: grey">(6767b2d)</span></li>
<li>tests/kplugins/main.cpp <span style="color: grey">(421e3fb)</span></li>
<li>tests/kplugins/plugintest.h <span style="color: grey">(a99701a)</span></li>
<li>tests/kplugins/plugintest.cpp <span style="color: grey">(3d98dec)</span></li>
<li>tests/testengine/testengine.cpp <span style="color: grey">(76947c3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126672/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7726225339212032843==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic