[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127199: Avoid blocking DBus calls in SNI startup
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-02-27 15:02:04
Message-ID: 20160227150204.22286.30121 () mimi ! kde ! org
[Download RAW message or body]
--===============6305316784441682246==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127199/#review92834
-----------------------------------------------------------
+1
dataengines/statusnotifieritem/statusnotifieritem_engine.cpp (line 98)
<https://git.reviewboard.kde.org/r/127199/#comment63304>
Typo: propetiesIface -> propertiesIface
Also, doesn't that constructor block? or is that fixed in 5.6?
- Kai Uwe Broulik
On Feb. 27, 2016, 2:58 nachm., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127199/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 2:58 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> All autogenerated qtdbus property fetches are synchronous.
>
> 1) Don't bother checking the protocol version.
> If the signals are the same, we may as well try and use the old signals,
> if it's not - the signals won't match anything anyway so it won't do
> anything anyway.
>
> 2) Replace the blocking RegisteredStatusNotifierItem request with an
> async variant.
>
> CCBUG: 359611
>
>
> Diffs
> -----
>
> dataengines/statusnotifieritem/CMakeLists.txt \
> c28312ea4292aaf9a610e5ff8435e08f520c7839 \
> dataengines/statusnotifieritem/statusnotifieritem_engine.cpp \
> 08a8c869f4e1a1445d15f3a4d9fb6fb7e62c3d32
> Diff: https://git.reviewboard.kde.org/r/127199/diff/
>
>
> Testing
> -------
>
> Ran statusnotifieritem test
> restarted plasmashell
> test icon showed up
>
>
> Thanks,
>
> David Edmundson
>
>
--===============6305316784441682246==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127199/">https://git.reviewboard.kde.org/r/127199/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127199/diff/1/?file=445689#file445689line98" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dataengines/statusnotifieritem/statusnotifieritem_engine.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">98</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">OrgFreedesktopDBusPropertiesInterface</span> <span \
class="nf">propetiesIface</span><span class="p">(</span><span \
class="n">m_statusNotifierWatcher</span><span class="o">-></span><span \
class="n">service</span><span class="p">(),</span> <span \
class="n">m_statusNotifierWatcher</span><span class="o">-></span><span \
class="n">path</span><span class="p">(),</span> <span \
class="n">m_statusNotifierWatcher</span><span class="o">-></span><span \
class="n">connection</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Typo: \
propetiesIface -> propertiesIface</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, doesn't that \
constructor block? or is that fixed in 5.6?</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Februar 27th, 2016, 2:58 nachm. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2016, 2:58 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All autogenerated qtdbus property fetches are synchronous.
1) Don't bother checking the protocol version.
If the signals are the same, we may as well try and use the old signals,
if it's not - the signals won't match anything anyway so it won't do
anything anyway.
2) Replace the blocking RegisteredStatusNotifierItem request with an
async variant.
CCBUG: 359611</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran statusnotifieritem test restarted plasmashell
test icon showed up</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/statusnotifieritem/CMakeLists.txt <span style="color: \
grey">(c28312ea4292aaf9a610e5ff8435e08f520c7839)</span></li>
<li>dataengines/statusnotifieritem/statusnotifieritem_engine.cpp <span style="color: \
grey">(08a8c869f4e1a1445d15f3a4d9fb6fb7e62c3d32)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127199/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6305316784441682246==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic