[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 10 lines] D1026: [FolderModel] Simplify deleting existing drag image
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-02-26 14:11:25
Message-ID: differential-rev-PHID-DREV-gcsfn3ytvcnvusxq5wjm-req () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of looking up three times (contains, value, remove) we just use take which \
removes the item and returns it and delete that. If there is no such item Qt promises \
to return a null pointer which is safe to delete.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1026

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, hein
Cc: plasma-devel


[Attachment #5 (text/html)]

<div>broulik created this revision.<br />
broulik added reviewers: Plasma, hein.<br />
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.<br />
broulik added a project: Plasma.<br />
Herald added a subscriber: plasma-devel.</div><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Instead of looking up three times (contains, value, remove) \
we just use take which removes the item and returns it and delete that. If there is \
no such item Qt promises to return a null pointer which is safe to \
delete.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP \
Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1026" \
rel="noreferrer">https://phabricator.kde.org/D1026</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/plugins/folder/foldermodel.cpp</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: \
</strong>plasma-devel<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]