[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127103: Add autotests for IconItem
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-02-18 11:20:51
Message-ID: 20160218112051.26765.91796 () mimi ! kde ! org
[Download RAW message or body]
--===============3941358075271515692==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127103/#review92524
-----------------------------------------------------------
Ship it!
autotests/iconitemtest.h (line 20)
<https://git.reviewboard.kde.org/r/127103/#comment63079>
Can we use this now?
- Kai Uwe Broulik
On Feb. 17, 2016, 5:37 nachm., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127103/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 5:37 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add some tests for IconItem.
> Also found one issue in animation when quickly changing source, first frame will be \
> rendered with wrong icon.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 258adb8
> autotests/data/icons/hicolor/22x22/apps/bug359388.svg PRE-CREATION
> autotests/data/view.qml PRE-CREATION
> autotests/iconitemtest.h PRE-CREATION
> autotests/iconitemtest.cpp PRE-CREATION
> src/declarativeimports/core/iconitem.cpp 085f284
>
> Diff: https://git.reviewboard.kde.org/r/127103/diff/
>
>
> Testing
> -------
>
> Tests pass localy, I used only icons that are shipped with plasma-framework breeze \
> theme so it should work on CI too.
> There is also test that checks if animation is not running after the item was \
> hidden. This needs https://git.reviewboard.kde.org/r/122859/, so this should land \
> only after that.
>
> Thanks,
>
> David Rosca
>
>
--===============3941358075271515692==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127103/">https://git.reviewboard.kde.org/r/127103/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127103/diff/1/?file=444564#file444564line20" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/iconitemtest.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">20</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#pragma once</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
we use this now?</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Februar 17th, 2016, 5:37 nachm. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2016, 5:37 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add some tests for IconItem. Also found one issue in \
animation when quickly changing source, first frame will be rendered with wrong \
icon.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests pass localy, I used only icons that are shipped \
with plasma-framework breeze theme so it should work on CI too.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There is also test that checks if animation is not running after the item \
was hidden. This needs https://git.reviewboard.kde.org/r/122859/, so this should land \
only after that.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(258adb8)</span></li>
<li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/data/view.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/iconitemtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(085f284)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127103/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3941358075271515692==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic