[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 127103: Add autotests for IconItem
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-02-17 17:37:08
Message-ID: 20160217173708.26765.18713 () mimi ! kde ! org
[Download RAW message or body]

--===============6115785934908979379==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127103/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-framework


Description
-------

Add some tests for IconItem.
Also found one issue in animation when quickly changing source, first frame will be \
rendered with wrong icon.


Diffs
-----

  autotests/CMakeLists.txt 258adb8 
  autotests/data/icons/hicolor/22x22/apps/bug359388.svg PRE-CREATION 
  autotests/data/view.qml PRE-CREATION 
  autotests/iconitemtest.h PRE-CREATION 
  autotests/iconitemtest.cpp PRE-CREATION 
  src/declarativeimports/core/iconitem.cpp 085f284 

Diff: https://git.reviewboard.kde.org/r/127103/diff/


Testing
-------

Tests pass localy, I used only icons that are shipped with plasma-framework breeze \
theme so it should work on CI too.

There is also test that checks if animation is not running after the item was hidden. \
This needs https://git.reviewboard.kde.org/r/122859/, so this should land only after \
that.


Thanks,

David Rosca


--===============6115785934908979379==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127103/">https://git.reviewboard.kde.org/r/127103/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add some tests for IconItem. Also found one issue in \
animation when quickly changing source, first frame will be rendered with wrong \
icon.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests pass localy, I used only icons that are shipped \
with plasma-framework breeze theme so it should work on CI too.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">There is also test that checks if animation is not running after the item \
was hidden. This needs https://git.reviewboard.kde.org/r/122859/, so this should land \
only after that.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(258adb8)</span></li>

 <li>autotests/data/icons/hicolor/22x22/apps/bug359388.svg <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/data/view.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/iconitemtest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/iconitemtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(085f284)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127103/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============6115785934908979379==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic