[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126878: [KRunner] Show single runner name
From: Thomas Pfeiffer <colomar () autistici ! org>
Date: 2016-02-11 17:17:16
Message-ID: 20160211171716.7653.75200 () mimi ! kde ! org
[Download RAW message or body]
--===============1586735254964334724==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote:
> > * A single runner can have multiple categories in its response.
> > * I see nothing from a technical point of view in the patch. I find it slightly \
> > ugly, but if the usability guys (and Plasma) are fine with it, ship it!
>
> Vishesh Handa wrote:
> *nothing wrong
>
> Marco Martin wrote:
> it is kinda ugly i think because is really unbalanced.ùif the window was larger \
> and the textbox taking at least half the width would probably look better (the fact \
> that it's german, so label longer than usual also doesn't help i guess)
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make it grow \
> accordingly. (is even easier code-wise)
> Marco Martin wrote:
> what about using PlaceholderText for the text filed instead?
> is not like you always need the runner name to be there
>
> Kai Uwe Broulik wrote:
> Good idea. However, doesn't it hide the placeholder as soon as the input has focus, \
> so you'll actually never see it? We could use a label for it though. Might even \
> make sense to have this always ie. "Search for documents, applications, ..."
> Usability Team, thoughts?
>
> Marco Martin wrote:
> good idea, (maybe even change the behavior of the placeholder altogether?)
> telegram desktop does that and doesn't appear to be particularly confusing..
>
> Thomas Pfeiffer wrote:
> Could you explain what you mean by "use a label for it"? What exactly would the \
> behavior be?
> Kai Uwe Broulik wrote:
> I meant a custom label so the placeholder text doesn't hide when the field has \
> focus but only if something is typed.
> Marco Martin wrote:
> basically behavior of the placeholder text going away
> a) when the text label gets focus
> b) only when you start typing
>
> to me, probably b) makes a bit more sense as i see it used a bit more around (like \
> firefox, telegram)
> Thomas Pfeiffer wrote:
> Ah okay, thx.
> In this case this definitely makes sense and I see it as a more elegant solution \
> than a label next to the field.
> I'll talk to Heiko to see if it makes sense to establish that behavior as the norm \
> in general. I tend towards yes, but I might miss a problem somehwere.
> Marco Martin wrote:
> I (think, if the qqc styling allows me) can change the behavior in our standard \
> text fields to make the placeholder disappear only upon typing
> Thomas Pfeiffer wrote:
> We had the idea that only those fields which automatically reseive focus keep their \
> placeholder, whereas the others still remove the placeholder when they are manually \
> focussed. That would mean that developers would have to set the behavior themselves \
> if they know a field automatically gets focus (like in the KRunner case).
> Marco Martin wrote:
> update: text fields always keep their placeholder until you start typing (that is \
> the behavior we need in this particular case), and we don't have any way to change \
> that from the plasma style
> Thomas Pfeiffer wrote:
> Oh, right, I just noticed. I's thought it was different. Weird. Ah well, then we're \
> all set anyway :)
> Kai Uwe Broulik wrote:
> So should I just show the runner name in the placeholder text, or "Search '%1'" / \
> "Search in '%1'" ? Though might not work for every runner name.
> Also, should there be a placeholdertext "Search..." (or "Search for applications, \
> documents, ...") if nothing is input?
> Thomas Pfeiffer wrote:
> I'd just use "Search...", because we can't list everything KRunner can search for, \
> and just showing some if it might be more confusing then helpful, plus we'd have to \
> check which runners are actually activated
> Kai Uwe Broulik wrote:
> So, if no runner is specified (the default) I show Search... and if single runner \
> mode is called, I show just the runner name?
Well, "Search [runner name]", to be precise :)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
-----------------------------------------------------------
On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126878/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 9:49 p.m.)
>
>
> Review request for Plasma, KDE Usability and Vishesh Handa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When in single runner mode (ie. only use a specific runner rather than querying \
> them all) show the name of the current runner.
> This restores Plasma 4 behavior and is also somewhat in preparation for the global \
> menu runner where it should be clear that I would currently be searching through \
> the current application's menu.
>
> Diffs
> -----
>
> lookandfeel/contents/runcommand/RunCommand.qml 43f7c55
>
> Diff: https://git.reviewboard.kde.org/r/126878/diff/
>
>
> Testing
> -------
>
> Name properly shows, layout works both ways without the window getting wider.
>
> I just noticed I could probably hide the category label next to the search result, \
> too, as it's now redundant but I don't know whether a runner can still set a \
> different value for that or if that's always just the runner name?
>
> File Attachments
> ----------------
>
> Runner name label
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============1586735254964334724==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126878/">https://git.reviewboard.kde.org/r/126878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 27th, 2016, 9 a.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">A single runner can have \
multiple categories in its response.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I see nothing from a \
technical point of view in the patch. I find it slightly ugly, but if the usability \
guys (and Plasma) are fine with it, ship it!</li> </ul></pre>
</blockquote>
<p>On January 28th, 2016, 9:11 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">*nothing wrong</p></pre> </blockquote>
<p>On January 28th, 2016, 9:23 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it is \
kinda ugly i think because is really unbalanced.ùif the window was larger and the \
textbox taking at least half the width would probably look better (the fact that it's \
german, so label longer than usual also doesn't help i guess)</p></pre> \
</blockquote>
<p>On January 28th, 2016, 10:04 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I explicitly made it so \
the runner window keeps its size but I can make it grow accordingly. (is even easier \
code-wise)</pre> </blockquote>
<p>On January 29th, 2016, 9:58 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
about using PlaceholderText for the text filed instead? is not like you always need \
the runner name to be there</p></pre> </blockquote>
<p>On January 29th, 2016, 10:30 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea. However, \
doesn't it hide the placeholder as soon as the input has focus, so you'll \
actually never see it? We could use a label for it though. Might even make sense to \
have this always ie. "Search for documents, applications, ..."
Usability Team, thoughts?</pre>
</blockquote>
<p>On January 29th, 2016, 10:42 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">good \
idea, (maybe even change the behavior of the placeholder altogether?) telegram \
desktop does that and doesn't appear to be particularly confusing..</p></pre> \
</blockquote>
<p>On January 29th, 2016, 11:57 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could \
you explain what you mean by "use a label for it"? What exactly would the behavior \
be?</p></pre> </blockquote>
<p>On January 29th, 2016, 12:13 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant a custom label \
so the placeholder text doesn't hide when the field has focus but only if \
something is typed.</pre> </blockquote>
<p>On January 29th, 2016, 12:22 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">basically behavior of the placeholder text going away a) when the text \
label gets focus b) only when you start typing</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">to me, probably b) makes a bit more sense as i see it \
used a bit more around (like firefox, telegram)</p></pre> </blockquote>
<p>On January 29th, 2016, 12:28 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah \
okay, thx. In this case this definitely makes sense and I see it as a more elegant \
solution than a label next to the field.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll talk to Heiko to \
see if it makes sense to establish that behavior as the norm in general. I tend \
towards yes, but I might miss a problem somehwere.</p></pre> </blockquote>
<p>On January 29th, 2016, 1:48 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
(think, if the qqc styling allows me) can change the behavior in our standard text \
fields to make the placeholder disappear only upon typing</p></pre> </blockquote>
<p>On January 29th, 2016, 1:52 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
had the idea that only those fields which automatically reseive focus keep their \
placeholder, whereas the others still remove the placeholder when they are manually \
focussed. That would mean that developers would have to set the behavior themselves \
if they know a field automatically gets focus (like in the KRunner case).</p></pre> \
</blockquote>
<p>On January 29th, 2016, 2:04 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">update: text fields always keep their placeholder until you start typing \
(that is the behavior we need in this particular case), and we don't have any way to \
change that from the plasma style</p></pre> </blockquote>
<p>On January 29th, 2016, 2:31 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, \
right, I just noticed. I's thought it was different. Weird. Ah well, then we're all \
set anyway :)</p></pre> </blockquote>
<p>On February 11th, 2016, 1:41 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
should I just show the runner name in the placeholder text, or "Search '%1'" / \
"Search in '%1'" ? Though might not work for every runner name.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also, should there be a placeholdertext "Search..." (or "Search for \
applications, documents, ...") if nothing is input?</p></pre> </blockquote>
<p>On February 11th, 2016, 4:44 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
just use "Search...", because we can't list everything KRunner can search for, and \
just showing some if it might be more confusing then helpful, plus we'd have to check \
which runners are actually activated</p></pre> </blockquote>
<p>On February 11th, 2016, 5 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, if no runner is \
specified (the default) I show Search... and if single runner mode is called, I show \
just the runner name?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
"Search [runner name]", to be precise :)</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On January 24th, 2016, 9:49 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 9:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When in single runner mode (ie. only use a specific \
runner rather than querying them all) show the name of the current runner.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This restores Plasma 4 behavior and is also somewhat in preparation for the \
global menu runner where it should be clear that I would currently be searching \
through the current application's menu.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Name properly shows, layout works both ways without \
the window getting wider.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I just noticed I could probably hide \
the category label next to the search result, too, as it's now redundant but I don't \
know whether a runner can still set a different value for that or if that's always \
just the runner name?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/runcommand/RunCommand.qml <span style="color: \
grey">(43f7c55)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126878/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png">Runner \
name label</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1586735254964334724==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic