'Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix
From:       René Fürst <rene () fuerst ! biz>
Date:       2016-02-02 22:17:23
Message-ID: 20160202221723.1720.15316 () mimi ! kde ! org
[Download RAW message or body]

--===============6524843745234408412==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125266/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 10:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for Network Management and Plasma.

Changes
-------

Submitted with commit b4c7cf28c3fea1ce54ca86d7d65494cc861b69bf by Lamarque V. Souza \
on behalf of Rene Furst to branch master.

Repository: plasma-nm

Description
-------

Authentication with certificates / Make MRU/MTU editable / Dialog fix

Diffs
-----

  vpn/l2tp/l2tp.ui bf35d02 
  vpn/l2tp/l2tpppp.ui 3c70165 
  vpn/l2tp/l2tppppwidget.cpp ffe2c2b 
  vpn/l2tp/l2tpwidget.h a161b53 
  vpn/l2tp/l2tpwidget.cpp a4ff42f 
  vpn/l2tp/nm-l2tp-service.h ac2ecc9 

Diff: https://git.reviewboard.kde.org/r/125266/diff/

Testing
-------

This patch contains 3 things:
1) Add authentication with certificates
2) Make MRU/MTU editable
3) Fix an issue where PPP/Advanced settings were lost when the dialogs were not \
opened

The base for 1) and 2) was added to NetworkManager-l2tp here \
https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c

File Attachments
----------------

Patch without indent changes
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff

Thanks,

René Fürst

--===============6524843745234408412==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125266/">https://git.reviewboard.kde.org/r/125266/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Network Management and Plasma.</div>
<div>By René Fürst.</div>

<p style="color: grey;"><i>Updated Feb. 2, 2016, 10:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b4c7cf28c3fea1ce54ca86d7d65494cc861b69bf by \
Lamarque V. Souza on behalf of Rene Furst to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Authentication with certificates / Make MRU/MTU \
editable / Dialog fix</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch contains 3 things: 1) Add authentication \
with certificates 2) Make MRU/MTU editable
3) Fix an issue where PPP/Advanced settings were lost when the dialogs were not \
opened</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The base for 1) and 2) was added to \
NetworkManager-l2tp here \
https://github.com/frenetic1/NetworkManager-l2tp/commit/8103cf09e2cda19d701a48331eba069ff4c8e82c</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>vpn/l2tp/l2tp.ui <span style="color: grey">(bf35d02)</span></li>

 <li>vpn/l2tp/l2tpppp.ui <span style="color: grey">(3c70165)</span></li>

 <li>vpn/l2tp/l2tppppwidget.cpp <span style="color: grey">(ffe2c2b)</span></li>

 <li>vpn/l2tp/l2tpwidget.h <span style="color: grey">(a161b53)</span></li>

 <li>vpn/l2tp/l2tpwidget.cpp <span style="color: grey">(a4ff42f)</span></li>

 <li>vpn/l2tp/nm-l2tp-service.h <span style="color: grey">(ac2ecc9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125266/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/e492aabf-c098-4ea7-bff0-30a13cc3fdda__cert_mru_mtu_dialog_fix4_noindent.diff">Patch \
without indent changes</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6524843745234408412==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 