'Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126942: LockScreen: Don't show layout variant in keyboard layout button
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-02-01 11:30:18
Message-ID: 20160201113018.1720.65502 () mimi ! kde ! org
[Download RAW message or body]

--===============4449471283539950245==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126942/#review91843
-----------------------------------------------------------

> but tooltip: "str" has no effect.

That's because kscreenlocker_greet is a QGuiApplication and QToolTip used by \
QtQuick.Controls requires QApplication

- Kai Uwe Broulik

On Feb. 1, 2016, 11:14 vorm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126942/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 11:14 vorm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Displaying layout variant makes the button too big.
> 
> 
> Diffs
> -----
> 
> lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 
> 
> Diff: https://git.reviewboard.kde.org/r/126942/diff/
> 
> 
> Testing
> -------
> 
> "de(nodeadkeys)" is now just "de"
> 
> Might be good idea to show full name in tooltip, but `tooltip: "str"` has no \
> effect. 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============4449471283539950245==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126942/">https://git.reviewboard.kde.org/r/126942/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">but tooltip: "str" has no effect.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">That's because kscreenlocker_greet is a \
QGuiApplication and QToolTip used by QtQuick.Controls requires QApplication</p></pre> \
<br />

<p>- Kai Uwe Broulik</p>

<br />
<p>On Februar 1st, 2016, 11:14 vorm. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Kai Uwe Broulik.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Feb. 1, 2016, 11:14 vorm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Displaying layout variant makes the button too \
big.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">"de(nodeadkeys)" is now just "de"</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Might be good idea to show full name in tooltip, but <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">tooltip: "str"</code> has no effect.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/components/KeyboardLayoutButton.qml <span style="color: \
grey">(0644f15)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126942/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4449471283539950245==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 