'Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126937: [KWindowSystemProxy] Add setter for showingDesktop
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-01-31 14:58:18
Message-ID: 20160131145818.17778.29633 () mimi ! kde ! org
[Download RAW message or body]

--===============6408003053060816931==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126937/
-----------------------------------------------------------

(Updated Jan. 31, 2016, 2:58 nachm.)

Review request for Plasma and Martin Gräßlin.

Repository: kdeclarative

Description
-------

I don't know why this was omitted.

Diffs
-----

  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h 3e47f00 
  src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp a70ce90 

Diff: https://git.reviewboard.kde.org/r/126937/diff/

Testing (updated)
-------

Works.

I added it to the lockscreen qml in hopes of finding a privacy vulnerability but the \
greeter window stayed there no matter what. :)

Thanks,

Kai Uwe Broulik

--===============6408003053060816931==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126937/">https://git.reviewboard.kde.org/r/126937/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 31, 2016, 2:58 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't know why this was omitted.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I added it to the \
lockscreen qml in hopes of finding a privacy vulnerability but the greeter window \
stayed there no matter what. :)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h <span style="color: \
grey">(3e47f00)</span></li>

 <li>src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp <span style="color: \
grey">(a70ce90)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126937/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6408003053060816931==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 