--===============5411475898143422593== Content-Type: multipart/alternative; boundary="===============4406388626113856712==" --===============4406388626113856712== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126593/#review91809 ----------------------------------------------------------- Hard to say if those items have to be placed at top or bottom. First impression is to have them rather at the bottom. But according the HIG "Place options that represent general options (e.g. All, None) at the beginning of the list." this patch is good. - Heiko Tietze On Jan. 1, 2016, 6:41 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126593/ > ----------------------------------------------------------- > > (Updated Jan. 1, 2016, 6:41 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-desktop > > > Description > ------- > > This just adds the jump list actions to the top of the menu as with all the other tasks. > > Is it better if we place the jump list actions below the list of windows? > > > Diffs > ----- > > applets/taskmanager/plugin/backend.cpp f83ae09 > > Diff: https://git.reviewboard.kde.org/r/126593/diff/ > > > Testing > ------- > > Works > > > File Attachments > ---------------- > > Jump List Action group > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/01/c0479186-77e7-4d33-bb6a-49b4abaf96f1__jumplistactionongroup.jpg > > > Thanks, > > Kai Uwe Broulik > > --===============4406388626113856712== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126593/

Hard to say if those items have to be placed at top or bottom. First impression is to have them rather at the bottom. But according the HIG "Place options that represent general options (e.g. All, None) at the beginning of the list." this patch is good.

- Heiko Tietze

On January 1st, 2016, 6:41 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma and KDE Usability.

By Kai Uwe Broulik.

Updated Jan. 1, 2016, 6:41 p.m.

Repository: plasma-desktop

Description

This just adds the jump list actions to the top of the menu as with all the other tasks.

Is it better if we place the jump list actions below the list of windows?

Testing

Works

Diffs

applets/taskmanager/plugin/backend.cpp (f83ae09)

View Diff

File Attachments

Jump List Action group

--===============4406388626113856712==-- --===============5411475898143422593== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============5411475898143422593==--