[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126878: [KRunner] Show single runner name
From: Marco Martin <notmart () gmail ! com>
Date: 2016-01-29 12:22:10
Message-ID: 20160129122210.17778.11563 () mimi ! kde ! org
[Download RAW message or body]
--===============8623998758319920270==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote:
> > * A single runner can have multiple categories in its response.
> > * I see nothing from a technical point of view in the patch. I find it slightly \
> > ugly, but if the usability guys (and Plasma) are fine with it, ship it!
>
> Vishesh Handa wrote:
> *nothing wrong
>
> Marco Martin wrote:
> it is kinda ugly i think because is really unbalanced.ùif the window was larger \
> and the textbox taking at least half the width would probably look better (the fact \
> that it's german, so label longer than usual also doesn't help i guess)
> Kai Uwe Broulik wrote:
> I explicitly made it so the runner window keeps its size but I can make it grow \
> accordingly. (is even easier code-wise)
> Marco Martin wrote:
> what about using PlaceholderText for the text filed instead?
> is not like you always need the runner name to be there
>
> Kai Uwe Broulik wrote:
> Good idea. However, doesn't it hide the placeholder as soon as the input has focus, \
> so you'll actually never see it? We could use a label for it though. Might even \
> make sense to have this always ie. "Search for documents, applications, ..."
> Usability Team, thoughts?
>
> Marco Martin wrote:
> good idea, (maybe even change the behavior of the placeholder altogether?)
> telegram desktop does that and doesn't appear to be particularly confusing..
>
> Thomas Pfeiffer wrote:
> Could you explain what you mean by "use a label for it"? What exactly would the \
> behavior be?
> Kai Uwe Broulik wrote:
> I meant a custom label so the placeholder text doesn't hide when the field has \
> focus but only if something is typed.
basically behavior of the placeholder text going away
a) when the text label gets focus
b) only when you start typing
to me, probably b) makes a bit more sense as i see it used a bit more around (like \
firefox, telegram)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126878/#review91645
-----------------------------------------------------------
On Jan. 24, 2016, 9:49 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126878/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 9:49 p.m.)
>
>
> Review request for Plasma, KDE Usability and Vishesh Handa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When in single runner mode (ie. only use a specific runner rather than querying \
> them all) show the name of the current runner.
> This restores Plasma 4 behavior and is also somewhat in preparation for the global \
> menu runner where it should be clear that I would currently be searching through \
> the current application's menu.
>
> Diffs
> -----
>
> lookandfeel/contents/runcommand/RunCommand.qml 43f7c55
>
> Diff: https://git.reviewboard.kde.org/r/126878/diff/
>
>
> Testing
> -------
>
> Name properly shows, layout works both ways without the window getting wider.
>
> I just noticed I could probably hide the category label next to the search result, \
> too, as it's now redundant but I don't know whether a runner can still set a \
> different value for that or if that's always just the runner name?
>
> File Attachments
> ----------------
>
> Runner name label
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============8623998758319920270==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126878/">https://git.reviewboard.kde.org/r/126878/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 27th, 2016, 9 a.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">A single runner can have \
multiple categories in its response.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I see nothing from a \
technical point of view in the patch. I find it slightly ugly, but if the usability \
guys (and Plasma) are fine with it, ship it!</li> </ul></pre>
</blockquote>
<p>On January 28th, 2016, 9:11 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">*nothing wrong</p></pre> </blockquote>
<p>On January 28th, 2016, 9:23 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it is \
kinda ugly i think because is really unbalanced.ùif the window was larger and the \
textbox taking at least half the width would probably look better (the fact that it's \
german, so label longer than usual also doesn't help i guess)</p></pre> \
</blockquote>
<p>On January 28th, 2016, 10:04 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I explicitly made it so \
the runner window keeps its size but I can make it grow accordingly. (is even easier \
code-wise)</pre> </blockquote>
<p>On January 29th, 2016, 9:58 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
about using PlaceholderText for the text filed instead? is not like you always need \
the runner name to be there</p></pre> </blockquote>
<p>On January 29th, 2016, 10:30 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea. However, \
doesn't it hide the placeholder as soon as the input has focus, so you'll \
actually never see it? We could use a label for it though. Might even make sense to \
have this always ie. "Search for documents, applications, ..."
Usability Team, thoughts?</pre>
</blockquote>
<p>On January 29th, 2016, 10:42 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">good \
idea, (maybe even change the behavior of the placeholder altogether?) telegram \
desktop does that and doesn't appear to be particularly confusing..</p></pre> \
</blockquote>
<p>On January 29th, 2016, 11:57 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could \
you explain what you mean by "use a label for it"? What exactly would the behavior \
be?</p></pre> </blockquote>
<p>On January 29th, 2016, 12:13 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant a custom label \
so the placeholder text doesn't hide when the field has focus but only if \
something is typed.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">basically behavior of the placeholder text going away a) when the text \
label gets focus b) only when you start typing</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">to me, probably b) makes a bit more sense as i see it \
used a bit more around (like firefox, telegram)</p></pre> <br />
<p>- Marco</p>
<br />
<p>On January 24th, 2016, 9:49 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2016, 9:49 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When in single runner mode (ie. only use a specific \
runner rather than querying them all) show the name of the current runner.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This restores Plasma 4 behavior and is also somewhat in preparation for the \
global menu runner where it should be clear that I would currently be searching \
through the current application's menu.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Name properly shows, layout works both ways without \
the window getting wider.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I just noticed I could probably hide \
the category label next to the search result, too, as it's now redundant but I don't \
know whether a runner can still set a different value for that or if that's always \
just the runner name?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/runcommand/RunCommand.qml <span style="color: \
grey">(43f7c55)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126878/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/24/d398ee71-78e5-458f-ad48-cf4fe828156f__runnername.png">Runner \
name label</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8623998758319920270==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic