--===============4276731963439398721== Content-Type: multipart/alternative; boundary="===============8231199806350665940==" --===============8231199806350665940== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/ ----------------------------------------------------------- (Updated Jan. 29, 2016, 5:11 p.m.) Review request for Plasma. Changes ------- file the bug on the bugzilla. Bugs: 358723 https://bugs.kde.org/show_bug.cgi?id=358723 Repository: plasma-workspace Description ------- The createWizardEntry() can return bool value to know if geting correct URL of new network folder(launching knetattach) failed. Due to the another bug(i'll send a patch for it), a blank entry is inserted to the UDSEntry list and cause to crash app (dolphin, gwenview and others using kcoredirlister) by clicking 'Network' in their placetree view. The empty UDS_NAME is not permmited. This fixes the bug by handling result of createWizardEntry(). Diffs ----- kioslave/remote/kio_remote.cpp ffee08c Diff: https://git.reviewboard.kde.org/r/126892/diff/ Testing ------- Confirmed to working fine with dolphin and gwenview (click 'Network' tree) And checked that no blank UDS_NAME in their placetree view. kioslave/remote/tests/testremote has been passed. Thanks, Takahiro Hashimoto --===============8231199806350665940== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/

Review request for Plasma.

By Takahiro Hashimoto.

Updated Jan. 29, 2016, 5:11 p.m.

Changes

file the bug on the bugzilla.

Bugs: 358723

Repository: plasma-workspace

Description

The createWizardEntry() can return bool value to know if geting correct URL of new network folder(launching knetattach) failed.
Due to the another bug(i'll send a patch for it), a blank entry is inserted to the UDSEntry list and cause to crash app (dolphin, gwenview and others using kcoredirlister) by clicking 'Network' in their placetree view. The empty UDS_NAME is not permmited.
This fixes the bug by handling result of createWizardEntry().

Testing

Confirmed to working fine with dolphin and gwenview (click 'Network' tree)
And checked that no blank UDS_NAME in their placetree view.

kioslave/remote/tests/testremote has been passed.

Diffs

kioslave/remote/kio_remote.cpp (ffee08c)

View Diff

--===============8231199806350665940==-- --===============4276731963439398721== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4276731963439398721==--