[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126907: [klipper] Remove "Don't ask again" on clear clipboard history
From: Thomas Pfeiffer <colomar () autistici ! org>
Date: 2016-01-27 15:55:23
Message-ID: 20160127155523.17778.42542 () mimi ! kde ! org
[Download RAW message or body]
--===============3866605814736923049==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126907/#review91669
-----------------------------------------------------------
So, the situation is not that special: We ask for confirmation to err on the side of \
caution (which makes sense since there is no going back) but don't want to bother \
users with dialogs they don't care about. In fact, the situation is quite similar to \
removing Plasmoids.
Before considering any non-optimal solutions, here is what would be best from a \
user's perspective: Do not ask for confirmation after deleting the history _but_ \
don't really delete it immediately. Instead, just hide it at first, and replace the \
empty history area with an "Undo" button. When the user adds the next entry to the \
list (or alternativwely after some time), actually delete the history and remove the \
Undo button.
Yes, this would certainly be more complex to implement, but it would make the dialog \
unnecessary while still allowing recovery in case of deletion by accident and would \
set a good precedent (or rather follow the precedent of Plasmoid removal).
- Thomas Pfeiffer
On Jan. 27, 2016, 2:13 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126907/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 2:13 p.m.)
>
>
> Review request for Plasma and Thomas Pfeiffer.
>
>
> Bugs: 336053
> https://bugs.kde.org/show_bug.cgi?id=336053
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When the clear clipboard history action is invoked klipper shows a
> message box asking whether that's really what the user intended as
> it's a potentially dangerous action (especially on a huge clipboard).
>
> But it also showed a "Don't ask again" checkbox which doesn't really
> make sense. When clicking "No" and the checkbox being checked it's
> becoming impossible to clear the clipboard which is probably not what
> the user intended.
>
> This change removes the "Don't ask again" checkbox.
>
> BUG: 336053
>
>
> Diffs
> -----
>
> klipper/klipper.cpp c80d2c7f470de2f071f59fb9629cf89a481e41c8
>
> Diff: https://git.reviewboard.kde.org/r/126907/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============3866605814736923049==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126907/">https://git.reviewboard.kde.org/r/126907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, \
the situation is not that special: We ask for confirmation to err on the side of \
caution (which makes sense since there is no going back) but don't want to bother \
users with dialogs they don't care about. In fact, the situation is quite similar to \
removing Plasmoids.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Before considering any non-optimal \
solutions, here is what would be best from a user's perspective: Do not ask for \
confirmation after deleting the history <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">but</em> don't really \
delete it immediately. Instead, just hide it at first, and replace the empty history \
area with an "Undo" button. When the user adds the next entry to the list (or \
alternativwely after some time), actually delete the history and remove the Undo \
button.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Yes, this would certainly be more complex to \
implement, but it would make the dialog unnecessary while still allowing recovery in \
case of deletion by accident and would set a good precedent (or rather follow the \
precedent of Plasmoid removal).</p></pre> <br />
<p>- Thomas Pfeiffer</p>
<br />
<p>On January 27th, 2016, 2:13 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Thomas Pfeiffer.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2016, 2:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=336053">336053</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the clear clipboard history action is invoked klipper shows a \
message box asking whether that's really what the user intended as it's a \
potentially dangerous action (especially on a huge clipboard).
But it also showed a "Don't ask again" checkbox which doesn't \
really make sense. When clicking "No" and the checkbox being checked \
it's becoming impossible to clear the clipboard which is probably not what
the user intended.
This change removes the "Don't ask again" checkbox.
BUG: 336053</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/klipper.cpp <span style="color: \
grey">(c80d2c7f470de2f071f59fb9629cf89a481e41c8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126907/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3866605814736923049==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic