[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: notes from the Plasma mobile components breakout session
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-01-27 12:54:56
Message-ID: CAGeFrHBf6AzU3UQKac0OqBmoAF8yKq43rF4j0XTeApA7gbXX9g () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


RefreshableScrollView

who sets requestingRefresh to false again? the app when it finishes
refreshing?
If so the property is more "refreshing" than "requestingRefresh"

API docs mising

Binding{} is better than 2 Connections to implement what effectively is a
binding
(and you have a bug here I'm sure, root.flickableItem.bottomMargin is set
to different things depending on whether the view or the content changed
last)

------------

ListItem

Given it doesn't contain a label AbstractListItem or BaseListItem would be
a better name

A subclass which then has the icon + text would be a good idea.

Docs for delegate for a section talks about showing a title. It doesn't.

Typo: otems -> items

    height: paddingItem.childrenRect.height + Units.smallSpacing*2
is automatically bound to implicitHeight. No point rebinding it to the same
thing manually

What's the purpose of the checked state that only changes the UI layer?
Do we want to make it checkable like a button?

Need to change the UI if we're enabled or not (grey out or something)

------------

ListItemWithActions

docs for actions looks like you copied and pasted it from Page.

Rather than doing JS searching for QAction and QQC Action look into
qmlRegisterExtendedType for QAction to make the properties match lower in
the stack

-----------------------

Heading

I don't really want this in here *and* in Plasma extras long term

and the doc formatting is randomly different.

---------------------
​
General:
 - accessibility needs doing

[Attachment #5 (text/html)]

<div dir="ltr"><div><div>RefreshableScrollView<br><br>who sets requestingRefresh to \
false again? the app when it finishes refreshing?<br>If so the property is more \
&quot;refreshing&quot; than &quot;requestingRefresh&quot;<br><br>API docs \
mising<br><br>Binding{} is better than 2 Connections to implement what effectively is \
a binding<br>(and you have a bug here I&#39;m sure, root.flickableItem.bottomMargin \
is set to different things depending on whether the view or the content changed \
last)<br><br>------------<br><br>ListItem<br><br>Given it doesn&#39;t contain a label \
AbstractListItem or BaseListItem would be a better name<br><br>A subclass which then \
has the icon + text would be a good idea.<br><br>Docs for delegate for a section \
talks about showing a title. It doesn&#39;t.<br><br>Typo: otems -&gt; items<br><br>   \
height: paddingItem.childrenRect.height + Units.smallSpacing*2<br>is automatically \
bound to implicitHeight. No point rebinding it to the same thing \
manually<br><br>What&#39;s the purpose of the checked state that only changes the UI \
layer?<br>Do we want to make it checkable like a button?<br><br>Need to change the UI \
if we&#39;re enabled or not (grey out or \
something)<br><br>------------<br><br>ListItemWithActions<br><br>docs for actions \
looks like you copied and pasted it from Page.<br><br>Rather than doing JS searching \
for QAction and QQC Action look into qmlRegisterExtendedType for QAction to make the \
properties match lower in the \
stack<br><br>-----------------------<br><br>Heading<br><br>I don&#39;t really want \
this in here *and* in Plasma extras long term<br><br></div><div>and the doc \
formatting is randomly \
different.<br></div><div><br>---------------------<br>​<br></div>General: \
<br></div>  - accessibility needs doing<br></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]