'Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-01-26 17:44:10
Message-ID: 20160126174410.17778.23691 () mimi ! kde ! org
[Download RAW message or body]

--===============6182550316487071930==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 5:44 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Jan Grulich and Lamarque Souza.

Changes
-------

Submitted with commit d8edcc6ab77836127f3cef5833bcd9e8a88a6e9f by Kai Uwe Broulik to \
branch master.

Repository: plasma-nm

Description
-------

It's quite natural that the connection goes away when we're about to suspend :) Watch \
for this and then don't emit the notification.

Diffs
-----

  kded/networkmanagement.notifyrc 7ce437c 
  kded/notification.h 9b8b51a 
  kded/notification.cpp 231d69e 

Diff: https://git.reviewboard.kde.org/r/126748/diff/

Testing
-------

While I still think Plasma-NM is waaaaaay too verbose about everything, at least it \
doesn't tell me that I just disconnected when I suspend.

I still get the notification when I turn off Wifi manually.
I also still get the notification that I'm connected again shortly after resuming.

Thanks,

Kai Uwe Broulik

--===============6182550316487071930==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126748/">https://git.reviewboard.kde.org/r/126748/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Jan Grulich and Lamarque Souza.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 26, 2016, 5:44 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit d8edcc6ab77836127f3cef5833bcd9e8a88a6e9f by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's quite natural that the connection goes away when \
we're about to suspend :) Watch for this and then don't emit the \
notification.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While I still think Plasma-NM is waaaaaay too verbose \
about everything, at least it doesn't tell me that I just disconnected when I \
suspend.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I still get the notification when I turn off Wifi \
manually. I also still get the notification that I'm connected again shortly after \
resuming.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kded/networkmanagement.notifyrc <span style="color: grey">(7ce437c)</span></li>

 <li>kded/notification.h <span style="color: grey">(9b8b51a)</span></li>

 <li>kded/notification.cpp <span style="color: grey">(231d69e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126748/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6182550316487071930==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 