'Re: Review Request 126843: Make kwallet-pam usable outside of Plasma'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126843: Make kwallet-pam usable outside of Plasma
From:       "Armin K." <krejzi () email ! com>
Date:       2016-01-26 11:17:54
Message-ID: 20160126111754.17778.30161 () mimi ! kde ! org
[Download RAW message or body]

--===============6283519650020346416==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126843/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 12:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Martin Klapetek.

Changes
-------

Submitted with commit c974341fe3502c46d275ff56ae36477ed7cc573d by Armin K to branch \
master.

Repository: kwallet-pam

Description
-------

Currently, kwallet-pam is only usable when used in combination with plasma5, becaue \
the code that connects PAM created socket to kwalletd is in startkde script.

Move that code into kwallet-pam itself and add an autostart desktop file so it can be \
used in plasma and outside of plasma (ie, gnome). Also add a check for socat \
executable, which is required to connect to the socket.

v2: Incorporate changes mentioned by Martin, remove CMake version requirement \
increase.

I tried using feature summary, but it wouldn't fail when I remove the executable.

v3: Readd cmake 2.8.12 requirement. rdieter confirmed it is a requirement for \
extra-cmake-modules, which is now being used by this package.

v4: Removed OnlyShownIn line from the desktop file as suggested by Xuetian and \
Martin.

Diffs
-----

  CMakeLists.txt 8bd526e 
  pam_kwallet_init PRE-CREATION 
  pam_kwallet_init.desktop.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126843/diff/

Testing
-------

Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was \
still asked for password in GNOME.

Thanks,

Armin K.

--===============6283519650020346416==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126843/">https://git.reviewboard.kde.org/r/126843/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Armin K..</div>

<p style="color: grey;"><i>Updated Jan. 26, 2016, 12:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c974341fe3502c46d275ff56ae36477ed7cc573d by Armin \
K to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet-pam
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, kwallet-pam is only usable when used in \
combination with plasma5, becaue the code that connects PAM created socket to \
kwalletd is in startkde script.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Move that code into \
kwallet-pam itself and add an autostart desktop file so it can be used in plasma and \
outside of plasma (ie, gnome). Also add a check for socat executable, which is \
required to connect to the socket.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">v2: Incorporate changes \
mentioned by Martin, remove CMake version requirement increase.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I tried using feature summary, but it wouldn't fail when I remove the \
executable.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">v3: Readd cmake 2.8.12 requirement. rdieter confirmed \
it is a requirement for extra-cmake-modules, which is now being used by this \
package.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">v4: Removed OnlyShownIn line from the desktop file as \
suggested by Xuetian and Martin.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works in both KDE Plasma and GNOME. Previously, it \
only worked in KDE Plasma, I was still asked for password in GNOME.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(8bd526e)</span></li>

 <li>pam_kwallet_init <span style="color: grey">(PRE-CREATION)</span></li>

 <li>pam_kwallet_init.desktop.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126843/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6283519650020346416==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 