'Re: Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126841: Use PlasmaCore.IconItem in Kicker, Kickoff and Folder View
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-01-26 9:43:12
Message-ID: 20160126094312.17778.72263 () mimi ! kde ! org
[Download RAW message or body]

--===============2939156145422787110==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126841/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 9:43 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 58193a3926be45219c3a01b50a39ce189180d75c by David Rosca to \
branch master.

Repository: plasma-desktop

Description
-------

Use PlasmaCore.IconItem with disabled animations and Plasma icon theme overlay when \
used to display app or folder icons.

Diffs
-----

  applets/kicker/package/contents/ui/ItemGridDelegate.qml fd9f5d3 
  applets/kicker/package/contents/ui/ItemListDelegate.qml 17925ae 
  applets/kickoff/package/contents/ui/KickoffItem.qml 98e19f9 
  containments/desktop/package/contents/ui/FolderItemDelegate.qml 6aaa361 
  containments/desktop/package/contents/ui/UpButtonItem.qml 83efe73 

Diff: https://git.reviewboard.kde.org/r/126841/diff/

Testing
-------

Uses exactly the same icons as before + uses correct color scheme for monochrome \
icons.

Thanks,

David Rosca

--===============2939156145422787110==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126841/">https://git.reviewboard.kde.org/r/126841/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated Jan. 26, 2016, 9:43 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 58193a3926be45219c3a01b50a39ce189180d75c by David \
Rosca to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use PlasmaCore.IconItem with disabled animations and \
Plasma icon theme overlay when used to display app or folder icons.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Uses exactly the same icons as before + uses correct \
color scheme for monochrome icons.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kicker/package/contents/ui/ItemGridDelegate.qml <span style="color: \
grey">(fd9f5d3)</span></li>

 <li>applets/kicker/package/contents/ui/ItemListDelegate.qml <span style="color: \
grey">(17925ae)</span></li>

 <li>applets/kickoff/package/contents/ui/KickoffItem.qml <span style="color: \
grey">(98e19f9)</span></li>

 <li>containments/desktop/package/contents/ui/FolderItemDelegate.qml <span \
style="color: grey">(6aaa361)</span></li>

 <li>containments/desktop/package/contents/ui/UpButtonItem.qml <span style="color: \
grey">(83efe73)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126841/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2939156145422787110==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 