'Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2016-01-25 14:10:28
Message-ID: 20160125141028.17778.73344 () mimi ! kde ! org
[Download RAW message or body]

--===============4332518345957766554==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126883/
-----------------------------------------------------------

Review request for KDE Frameworks, Plasma and Marco Martin.

Repository: kpackage

Description
-------

This method is intended to replace contentsHash which operates only
on Sha1. In order to support more secure hashing algorithmns and also
to support future developments the new implementation does not hard
code the algorithm but allows to specify it. By that the existing
implementation can just delegate to the new one.

Another change in the implementation is that the new cryptographicHash
method returns a QByteArray instead of a QString. As only a hex
representation of the hash is returned the conversion to QString is
not necessary.

Package::contentsHash() is marked as deprecated.

Diffs
-----

  autotests/plasmoidpackagetest.cpp 69f45f57bbec5c0f6d2268869249606c50338765 
  src/kpackage/package.h b97b70be42df7d9fd09e3fb4e7b82b00ef970be3 
  src/kpackage/package.cpp 4c0f671965d9ed33b9f52b06205bf6ffcda94c8a 

Diff: https://git.reviewboard.kde.org/r/126883/diff/

Testing
-------

Thanks,

Martin Gräßlin

--===============4332518345957766554==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126883/">https://git.reviewboard.kde.org/r/126883/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This method is intended to replace contentsHash which operates only on \
Sha1. In order to support more secure hashing algorithmns and also to support future \
developments the new implementation does not hard code the algorithm but allows to \
specify it. By that the existing implementation can just delegate to the new one.

Another change in the implementation is that the new cryptographicHash
method returns a QByteArray instead of a QString. As only a hex
representation of the hash is returned the conversion to QString is
not necessary.

Package::contentsHash() is marked as deprecated.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/plasmoidpackagetest.cpp <span style="color: \
grey">(69f45f57bbec5c0f6d2268869249606c50338765)</span></li>

 <li>src/kpackage/package.h <span style="color: \
grey">(b97b70be42df7d9fd09e3fb4e7b82b00ef970be3)</span></li>

 <li>src/kpackage/package.cpp <span style="color: \
grey">(4c0f671965d9ed33b9f52b06205bf6ffcda94c8a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126883/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4332518345957766554==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 