'Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after c'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after c
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-01-24 16:39:38
Message-ID: 20160124163938.17778.84197 () mimi ! kde ! org
[Download RAW message or body]

--===============0071119042632273991==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Ян. 24, 2016, 4:43 след обяд, David Edmundson wrote:
> > > Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip \
> > > animation transition between item to decrease it permormance
> > 
> > Why does QPropertyAnimation decrease in performance after suspend/restore?
> > 
> > Other than the KWindowSystem change I don't see what this is going to alter. \
> > You're removing a QPropertyAnimation when it's unused, which won't make a \
> > difference as it'll be unused anyway.
> 
> Anthony Fieroni wrote:
> It's not only 1 circle suspend/resume, it's couple of days. I cannot say \
> QPropertyAnimation is buggy, but i see it allocated once and lifetime is same as \
> panel, read fps are dropped in some summy day :) At same sunny day if you add new \
> panel, animation is great on newly panel with fresh QPropertyAnimation allocated \
> pointer, so let *refresh* the pointer :) 
> David Edmundson wrote:
> Do you have a link to the Qt bug for QPropertyAnimation?

No, only mine test here.

- Anthony

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126870/#review91521
-----------------------------------------------------------

On Ян. 24, 2016, 5:20 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126870/
> -----------------------------------------------------------
> 
> (Updated Ян. 24, 2016, 5:20 след обяд)
> 
> 
> Review request for KDE Frameworks, Plasma and David Edmundson.
> 
> 
> Bugs: 354353
> http://bugs.kde.org/show_bug.cgi?id=354353
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip \
> animation transition between item to decrease it permormance and looks quite ugly. \
> If add new panel animation is *cool* as is. The perfermonce decrease can be cause \
> due to swap use, or QPropertyAnimation issue, however we (you KDE defs and i *like \
> a user*) wants plasmashell and it's components (like panel) to works *forever* 
> 
> Diffs
> -----
> 
> src/declarativeimports/core/tooltip.cpp a5e223b 
> src/declarativeimports/core/tooltipdialog.h 2ea8af9 
> src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
> 
> Diff: https://git.reviewboard.kde.org/r/126870/diff/
> 
> 
> Testing
> -------
> 
> Workaround is quite simple:
> Animation is refreshed as is, pointer hasn't same lifetime as panel
> + Animation is disabled if compositing is not active
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
> 

--===============0071119042632273991==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126870/">https://git.reviewboard.kde.org/r/126870/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Януари 24th, 2016, 4:43 след обяд \
EET, <b>David Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: \
inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 \
0 0 0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Continous usage, read \
as suspend/resume/use and so on, cause <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">cool</em> tooltip \
animation transition between item to decrease it permormance</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Why does QPropertyAnimation decrease in performance \
after suspend/restore?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Other than the KWindowSystem change I \
don't see what this is going to alter. You're removing a QPropertyAnimation when it's \
unused, which won't make a difference as it'll be unused anyway.</p></pre>  \
</blockquote>

On Януари 24th, 2016, 5:13 след обяд EET, Anthony Fieroni \
wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not only 1 circle suspend/resume, it's couple of days. I cannot say \
QPropertyAnimation is buggy, but i see it allocated once and lifetime is same as \
panel, read fps are dropped in some summy day :) At same sunny day if you add new \
panel, animation is great on newly panel with fresh QPropertyAnimation allocated \
pointer, so let refresh the pointer :)</pre> </blockquote>

 <p>On Януари 24th, 2016, 6 след обяд EET, <b>David Edmundson</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Do you have a link to the Qt bug for QPropertyAnimation?</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
only mine test here.</p></pre> <br />

<p>- Anthony</p>

<br />
<p>On Януари 24th, 2016, 5:20 след обяд EET, Anthony Fieroni wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and David Edmundson.</div>
<div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Ян. 24, 2016, 5:20 след обяд</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=354353">354353</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Continous usage, read as suspend/resume/use and so on, \
cause <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">cool</em> tooltip animation transition between item to \
decrease it permormance and looks quite ugly. If add new panel animation is <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">cool</em> as is. The perfermonce decrease can be cause due to swap use, or \
QPropertyAnimation issue, however we (you KDE defs and i <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">like a \
user</em>) wants plasmashell and it's components (like panel) to works <em \
style="padding: 0;text-rendering:  inherit;margin: 0;line-height: \
inherit;white-space: normal;">forever</em></p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Workaround is quite simple: Animation is refreshed as \
is, pointer hasn't same lifetime as panel + Animation is disabled if compositing is \
not active</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(a5e223b)</span></li>

 <li>src/declarativeimports/core/tooltipdialog.h <span style="color: \
grey">(2ea8af9)</span></li>

 <li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: \
grey">(6c3712e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126870/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0071119042632273991==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 