[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-01-23 13:36:48
Message-ID: 20160123133648.5219.1312 () mimi ! kde ! org
[Download RAW message or body]
--===============9102150107289095876==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 23, 2016, 1:22 nachm., Kai Uwe Broulik wrote:
> > id isn't particularly better either as that's also a reserved QML keyword.
> >
> > Also, you can access any role with a name clash by accessing it through "model", \
> > ie. model.index
>
> Daniel Faust wrote:
> id is the first thing that came to mind, of cause it could be called something else \
> as well. (suggestions?)
> I know that I can access the model role through the model variable, but I want to \
> access the ListView's index variable.
Right. Perhaps "itemIndex" / "placeIndex" instead? It also seems that "id" and \
"index" aren't the same thing? So we shouldn't just remove the one in favor of the \
other.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126851/#review91476
-----------------------------------------------------------
On Jan. 23, 2016, 1:14 nachm., Daniel Faust wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126851/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 1:14 nachm.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> I wrote a qml applet using the places data engine and noticed that I can't access \
> the index variable of ListView items because it gets overwritten by the places \
> model. This patch renames the "index" role name to "id" in order to avoid this \
> naming conflict.
>
> Diffs
> -----
>
> dataengines/places/org.kde.places.operations 98a951d
> dataengines/places/placeservice.cpp e0c93c5
> dataengines/places/placesproxymodel.h 467fe83
> dataengines/places/placesproxymodel.cpp 5ea807b
>
> Diff: https://git.reviewboard.kde.org/r/126851/diff/
>
>
> Testing
> -------
>
> I couldn't find any other model that is using the places data engine so I hope \
> renaming the model role is fine. The provided model still works and I tested the \
> "Setup Device" and "Teardown Device" operations of the service. The operations \
> "Show" and "Hide" don't seem to work anyway and the others were not tested.
>
> Thanks,
>
> Daniel Faust
>
>
--===============9102150107289095876==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126851/">https://git.reviewboard.kde.org/r/126851/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Januar 23rd, 2016, 1:22 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">id isn't particularly better either as that's also a \
reserved QML keyword.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also, you can access any role with a \
name clash by accessing it through "model", ie. model.index</p></pre> </blockquote>
<p>On Januar 23rd, 2016, 1:30 nachm. UTC, <b>Daniel Faust</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">id is \
the first thing that came to mind, of cause it could be called something else as \
well. (suggestions?)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I know that I can access the model role \
through the model variable, but I want to access the ListView's index \
variable.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right. Perhaps "itemIndex" / "placeIndex" instead? It also seems that "id" \
and "index" aren't the same thing? So we shouldn't just remove the one in favor of \
the other.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Januar 23rd, 2016, 1:14 nachm. UTC, Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2016, 1:14 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I wrote a qml applet using the places data engine and \
noticed that I can't access the index variable of ListView items because it gets \
overwritten by the places model. This patch renames the "index" role name to "id" in \
order to avoid this naming conflict.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I couldn't find any other model that is using the \
places data engine so I hope renaming the model role is fine. The provided model \
still works and I tested the "Setup Device" and "Teardown Device" operations of the \
service. The operations "Show" and "Hide" don't seem to work anyway and the others \
were not tested.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/places/org.kde.places.operations <span style="color: \
grey">(98a951d)</span></li>
<li>dataengines/places/placeservice.cpp <span style="color: \
grey">(e0c93c5)</span></li>
<li>dataengines/places/placesproxymodel.h <span style="color: \
grey">(467fe83)</span></li>
<li>dataengines/places/placesproxymodel.cpp <span style="color: \
grey">(5ea807b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126851/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9102150107289095876==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic