'Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-01-19 20:42:36
Message-ID: 20160119204236.4401.78156 () mimi ! kde ! org
[Download RAW message or body]

--===============5872178165973725564==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Jan. 19, 2016, 8:41 nachm., Kai Uwe Broulik wrote:
> > Doesn't compile, contextualActionsAboutToShow is in the Applet*interface* not \
> > Applet.

Also, it should probably call it on the currently active applet, not the system tray.

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126811/#review91348
-----------------------------------------------------------

On Jan. 19, 2016, 12:25 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126811/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 12:25 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Normally done by the containment interface
> 
> BUG: 358119
> 
> 
> Diffs
> -----
> 
> applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp \
> ca672c5e58546e2e199fd6d1dd403600e79e6f8c  
> Diff: https://git.reviewboard.kde.org/r/126811/diff/
> 
> 
> Testing
> -------
> 
> Literally none. I assume Kai has something.
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============5872178165973725564==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126811/">https://git.reviewboard.kde.org/r/126811/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Januar 19th, 2016, 8:41 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Doesn't compile, contextualActionsAboutToShow is in \
the Applet<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">interface</em> not Applet.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, \
it should probably call it on the currently active applet, not the system \
tray.</p></pre> <br />

<p>- Kai Uwe</p>

<br />
<p>On Januar 19th, 2016, 12:25 nachm. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Jan. 19, 2016, 12:25 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Normally done by the containment interface</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">BUG: 358119</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Literally none. I assume Kai has something.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp <span \
style="color: grey">(ca672c5e58546e2e199fd6d1dd403600e79e6f8c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126811/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5872178165973725564==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 