[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2016-01-14 21:08:48
Message-ID: 20160114210848.14175.93281 () mimi ! kde ! org
[Download RAW message or body]
--===============8686878848647449270==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote:
> > It should probably still show when you get disconnected and *not* reconnected (to \
> > any network) on resume?
>
> Kai Uwe Broulik wrote:
> Doesn't it tell you that anyway? At least when I try to connect to something and it \
> fails I get like 3 notifications about different failures.
> Martin Klapetek wrote:
> What I mean is when you suspend your laptop at home, connected to your home \
> network, you go out and resume your laptop say at your friend where you didn't \
> connect to the wifi before, so it's unknown and your laptop will not connect to \
> anything and will not even try. At that point, it should show a "disconnected" \
> notification, maybe?
Ah, I see. How should I do that? If it disconnected on suspend and didn't attempt to \
reconnect within 5 seconds show a notification that you're no longer connected?
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126748/#review91107
-----------------------------------------------------------
On Jan. 14, 2016, 6:19 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126748/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 6:19 nachm.)
>
>
> Review request for Plasma and Jan Grulich.
>
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> It's quite natural that the connection goes away when we're about to suspend :) \
> Watch for this and then don't emit the notification.
>
> Diffs
> -----
>
> kded/notification.h 9b8b51a
> kded/notification.cpp 231d69e
>
> Diff: https://git.reviewboard.kde.org/r/126748/diff/
>
>
> Testing
> -------
>
> While I still think Plasma-NM is waaaaaay too verbose about everything, at least it \
> doesn't tell me that I just disconnected when I suspend.
> I still get the notification when I turn off Wifi manually.
> I also still get the notification that I'm connected again shortly after resuming.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============8686878848647449270==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126748/">https://git.reviewboard.kde.org/r/126748/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Januar 14th, 2016, 6:22 nachm. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It should probably still show when you get disconnected and *not* \
reconnected (to any network) on resume?</pre> </blockquote>
<p>On Januar 14th, 2016, 6:33 nachm. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Doesn't it tell you that anyway? At least when I try to connect to \
something and it fails I get like 3 notifications about different failures.</p></pre> \
</blockquote>
<p>On Januar 14th, 2016, 6:37 nachm. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
I mean is when you suspend your laptop at home, connected to your home network, you \
go out and resume your laptop say at your friend where you didn't connect to the wifi \
before, so it's unknown and your laptop will not connect to anything and will not \
even try. At that point, it should show a "disconnected" notification, \
maybe?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, I \
see. How should I do that? If it disconnected on suspend and didn't attempt to \
reconnect within 5 seconds show a notification that you're no longer \
connected?</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Januar 14th, 2016, 6:19 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Jan Grulich.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2016, 6:19 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's quite natural that the connection goes away when \
we're about to suspend :) Watch for this and then don't emit the \
notification.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While I still think Plasma-NM is waaaaaay too verbose \
about everything, at least it doesn't tell me that I just disconnected when I \
suspend.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I still get the notification when I turn off Wifi \
manually. I also still get the notification that I'm connected again shortly after \
resuming.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/notification.h <span style="color: grey">(9b8b51a)</span></li>
<li>kded/notification.cpp <span style="color: grey">(231d69e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126748/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8686878848647449270==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic