[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126730: cleanup sddm kcm
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2016-01-13 0:27:06
Message-ID: 20160113002706.23702.20258 () mimi ! kde ! org
[Download RAW message or body]
--===============6916827758645412304==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126730/#review90984
-----------------------------------------------------------
Ship it!
src/themesdelegate.cpp (line 134)
<https://git.reviewboard.kde.org/r/126730/#comment62151>
do't write "*1" just delete that bit
- David Edmundson
On Jan. 13, 2016, 12:21 a.m., andreas kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126730/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 12:21 a.m.)
>
>
> Review request for Plasma and Heiko Tietze.
>
>
> Repository: sddm-kcm
>
>
> Description
> -------
>
> remove the webpage and the author in the overview cause this is shown in the \
> preview section.
>
> Diffs
> -----
>
> src/themesdelegate.cpp 1b528a0
> src/ui/advanceconfig.ui e7fcb97
> src/ui/themeconfig.ui 33cc685
>
> Diff: https://git.reviewboard.kde.org/r/126730/diff/
>
>
> Testing
> -------
>
> after this cleanup there is one point open but therefore I need someone with real \
> coding skills.
> KCM HIG https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application
>
> don't use tabs -> add an more button.
>
> So you have an select area and an preview area as in my point of view the Auto \
> Login is an "standard setting" I would add the auto login section on bottom of the \
> select area. On the bottom page you have an botton
> - use userdefined background
> - advanced setting
> - import from file (now not available)
> - import from GHNS (now not available)
>
>
> File Attachments
> ----------------
>
> sddm-kcm.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/13/483cf282-99b2-4c26-ab51-0d415d3fdf5e__sddm-kcm.png
>
>
> Thanks,
>
> andreas kainz
>
>
--===============6916827758645412304==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126730/">https://git.reviewboard.kde.org/r/126730/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126730/diff/1/?file=430506#file430506line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/themesdelegate.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ThemesDelegate::paint(QPainter *painter,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">145</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">document</span><span class="p">.</span><span \
class="n">drawContents</span><span class="p">(</span><span \
class="n">painter</span><span class="p">,</span> <span class="n">QRect</span><span \
class="p">(</span><span class="n">QPoint</span><span class="p">(</span><span \
class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">),</span> <span class="n">option</span><span class="p">.</span><span \
class="n">rect</span><span class="p">.</span><span class="n">size</span><span \
class="p">()</span> <span class="o">-</span> <span class="n">QSize</span><span \
class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="n">m_maxHeight</span> <span class="o">+</span> <span class="n">MARGIN</span> \
<span class="o">*</span> <span class="mi"><span class="hl">2</span></span><span \
class="p">)));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">134</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">document</span><span \
class="p">.</span><span class="n">drawContents</span><span class="p">(</span><span \
class="n">painter</span><span class="p">,</span> <span class="n">QRect</span><span \
class="p">(</span><span class="n">QPoint</span><span class="p">(</span><span \
class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">),</span> <span class="n">option</span><span class="p">.</span><span \
class="n">rect</span><span class="p">.</span><span class="n">size</span><span \
class="p">()</span> <span class="o">-</span> <span class="n">QSize</span><span \
class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="n">m_maxHeight</span> <span class="o">+</span> <span class="n">MARGIN</span> \
<span class="o">*</span> <span class="mi"><span class="hl">1</span></span><span \
class="p">)));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">do't \
write "*1" just delete that bit</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On January 13th, 2016, 12:21 a.m. UTC, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Heiko Tietze.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2016, 12:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sddm-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">remove the webpage and the author in the overview \
cause this is shown in the preview section.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">after this cleanup there is one point open but \
therefore I need someone with real coding skills.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KCM \
HIG https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">don't use tabs -> add an more button.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">So you have an select area and an preview area as in my point of view the \
Auto Login is an "standard setting" I would add the auto login section on bottom of \
the select area. On the bottom page you have an botton
- use userdefined background
- advanced setting
- import from file (now not available)
- import from GHNS (now not available)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/themesdelegate.cpp <span style="color: grey">(1b528a0)</span></li>
<li>src/ui/advanceconfig.ui <span style="color: grey">(e7fcb97)</span></li>
<li>src/ui/themeconfig.ui <span style="color: grey">(33cc685)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126730/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/13/483cf282-99b2-4c26-ab51-0d415d3fdf5e__sddm-kcm.png">sddm-kcm.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6916827758645412304==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic