[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126669: [Task Manager] Don't show on which virtual desktop a window is if there i
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2016-01-11 17:13:34
Message-ID: 20160111171334.23702.7377 () mimi ! kde ! org
[Download RAW message or body]
--===============7070335366153166393==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126669/#review90919
-----------------------------------------------------------
According to git log it did end up in Plasma/5.5 branch but the close hook didn't \
work yesterday for some reason.
- Kai Uwe Broulik
On Jan. 10, 2016, 6:11 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126669/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 6:11 nachm.)
>
>
> Review request for Plasma, KDE Usability and Eike Hein.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> There's no point.
>
>
> Diffs
> -----
>
> applets/taskmanager/package/contents/ui/Task.qml 2a88886
> applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 4bf0b31
> applets/taskmanager/plugin/backend.h 3879d94
> applets/taskmanager/plugin/backend.cpp f83ae09
>
> Diff: https://git.reviewboard.kde.org/r/126669/diff/
>
>
> Testing
> -------
>
> With one virtual desktop -> it doesn't say anything
> With more than one virtual desktop -> says on which virtual desktop a window is on
>
> The text regarding on which activity a window is on is unchanged, as it doesn't \
> show up if a window is only associated with the current activity anyway
>
> File Attachments
> ----------------
>
> No virtual desktop mentioned
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/e343ed65-c29d-4fdc-bb51-adc9b9e29138__tooltipnovirtualdesktop.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============7070335366153166393==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126669/">https://git.reviewboard.kde.org/r/126669/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">According to git log it did end up in Plasma/5.5 branch but the close hook \
didn't work yesterday for some reason.</p></pre> <br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Januar 10th, 2016, 6:11 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2016, 6:11 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There's no point.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With one virtual desktop -> it doesn't say anything \
With more than one virtual desktop -> says on which virtual desktop a window is \
on</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The text regarding on which activity a window is on is \
unchanged, as it doesn't show up if a window is only associated with the current \
activity anyway</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(2a88886)</span></li>
<li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(4bf0b31)</span></li>
<li>applets/taskmanager/plugin/backend.h <span style="color: \
grey">(3879d94)</span></li>
<li>applets/taskmanager/plugin/backend.cpp <span style="color: \
grey">(f83ae09)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126669/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/e343ed65-c29d-4fdc-bb51-adc9b9e29138__tooltipnovirtualdesktop.png">No \
virtual desktop mentioned</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7070335366153166393==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic