[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126713: fix font preview colors
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2016-01-10 22:33:46
Message-ID: 20160110223346.23702.40533 () mimi ! kde ! org
[Download RAW message or body]
--===============6394529233594547861==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote:
> > Can I suggest you copy SNIProxy::convertFromNative from \
> > plasma-workspace/xembedsniproxy/sniproxy.cpp
> > (which in itself is copied from KWindowSystem, which I think was copied from \
> > Qt....)
...or maybe I should be the one copying this. I have a completely lying comment \
about Format_RGB30 not existing.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126713/#review90858
-----------------------------------------------------------
On Jan. 10, 2016, 10:12 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126713/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 10:12 p.m.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Bugs: 336089
> https://bugs.kde.org/show_bug.cgi?id=336089
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> the image format was hardcoded to ARGB32_Premultiplied, but that's not generally \
> correct, notably not on 24bit servers
>
> Diffs
> -----
>
> kcms/kfontinst/lib/FcEngine.cpp 19b7206
>
> Diff: https://git.reviewboard.kde.org/r/126713/diff/
>
>
> Testing
> -------
>
> yes, bug.
>
>
> Thanks,
>
> Thomas Lübking
>
>
--===============6394529233594547861==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126713/">https://git.reviewboard.kde.org/r/126713/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 10th, 2016, 10:31 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can I suggest you copy SNIProxy::convertFromNative \
from plasma-workspace/xembedsniproxy/sniproxy.cpp</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(which in itself is copied from KWindowSystem, which I think was copied \
from Qt....)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">...or \
maybe I should be the one copying this. I have a completely lying comment about \
Format_RGB30 not existing.</p></pre> <br />
<p>- David</p>
<br />
<p>On January 10th, 2016, 10:12 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2016, 10:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=336089">336089</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the image format was hardcoded to \
ARGB32_Premultiplied, but that's not generally correct, notably not on 24bit \
servers</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">yes, bug.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/kfontinst/lib/FcEngine.cpp <span style="color: grey">(19b7206)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126713/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6394529233594547861==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic