'Re: Review Request 126356: change minimum size of clipboard'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126356: change minimum size of clipboard
From:       "andreas kainz" <kainz.a () gmail ! com>
Date:       2016-01-09 21:49:19
Message-ID: 20160109214919.6499.12451 () mimi ! kde ! org
[Download RAW message or body]

--===============8614471530131403130==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/
-----------------------------------------------------------

(Updated Jan. 9, 2016, 9:49 p.m.)

Review request for Plasma.

Changes
-------

ok as david say the minimum usefull size I change the minimum size to the minimum \
useful now it clould be used also in the sidebar

Repository: plasma-workspace

Description
-------

if you use clipboard on the desktop the minimum window height is heigher than you use \
clipboard from the panel (drop down window). As the user can define the width and \
height for the desktop plasmoid the minimum allowed height should be at least the \
same than the drop down window in the panel. so I change the minimumHeig to 16.

Diffs (updated)
-----

  applets/clipboard/contents/ui/clipboard.qml 97230c1 

Diff: https://git.reviewboard.kde.org/r/126356/diff/

Testing
-------

File Attachments
----------------

old before with 26 min height
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
 new after with 16 min height
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png

Thanks,

andreas kainz

--===============8614471530131403130==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126356/">https://git.reviewboard.kde.org/r/126356/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By andreas kainz.</div>

<p style="color: grey;"><i>Updated Jan. 9, 2016, 9:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ok as david say the minimum usefull size I change the minimum size to \
the minimum useful now it clould be used also in the sidebar</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if you use clipboard on the desktop the minimum window \
height is heigher than you use clipboard from the panel (drop down window). As the \
user can define the width and height for the desktop plasmoid the minimum allowed \
height should be at least the same than the drop down window in the panel. so I \
change the minimumHeig to 16.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/clipboard/contents/ui/clipboard.qml <span style="color: \
grey">(97230c1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126356/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png">old \
before with 26 min height</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png">new \
after with 16 min height</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8614471530131403130==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 