[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126647: [Task Manager] Provide media controls in tooltips
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2016-01-07 21:05:24
Message-ID: 20160107210524.6499.3305 () mimi ! kde ! org
[Download RAW message or body]
--===============6200087773857775969==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 9:05 nachm.)
Review request for Plasma, KDE Usability and Eike Hein.
Changes
-------
* Allow raising player through MPris, if supported, even if the player window is not \
there
* Rebase on recent changes to ToolTipDelegate
Bugs: 352126
https://bugs.kde.org/show_bug.cgi?id=352126
Repository: plasma-desktop
Description
-------
This adds media player controls to the tooltip of a media player, using the already \
existing mpris dataengine this was pretty straightforward to implement.
When album art is available, no window thumbnails will be shown, instead the album \
art. There will be a close button on the album art closing the first window. Multiple \
windows for a player is uncommon and you can still access them all by clicking the \
task manager entry.
Interestingly enough, Amarok does not expose its album art through MPris. Also, if it \
wouldn't crash whilst doing so, you could control Amarok when it's main window is \
closed if you have a launcher pinned to your task manager, basically rendering its \
tray icon obsolete.
Diffs (updated)
-----
applets/taskmanager/package/contents/ui/Task.qml 2a88886
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 4bf0b31
Diff: https://git.reviewboard.kde.org/r/126647/diff/
Testing
-------
Works with VLC and Audacious, does not work with Dragon as the player announces \
itself as "dragonplayer" while its Desktop file says "dragon"
File Attachments (updated)
----------------
VLC with album art
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/3058dacb-1dfd-464d-a1ec-be90bc9e58a8__mpristaskmanagerreview1.png
Amarok without album art
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/6799d6f6-d505-4f56-9531-3013a3e34ae6__mpristaskmanagerreview2.png
No gradient
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/06/25298761-28bb-4620-b768-dd0259f19b82__mpristaskmanagerreview3.png
Raising Amarok through its launcher
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/8dfcb9b6-6e11-4017-b4fc-70d92c9ded2a__mpristaskmanagerreview4.png
Thanks,
Kai Uwe Broulik
--===============6200087773857775969==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126647/">https://git.reviewboard.kde.org/r/126647/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2016, 9:05 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Allow raising player through MPris, if supported, even if the player \
window is not there
* Rebase on recent changes to ToolTipDelegate</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=352126">352126</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds media player controls to the tooltip of a \
media player, using the already existing mpris dataengine this was pretty \
straightforward to implement.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">When album art is \
available, no window thumbnails will be shown, instead the album art. There will be a \
close button on the album art closing the first window. Multiple windows for a player \
is uncommon and you can still access them all by clicking the task manager entry.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Interestingly enough, Amarok does not expose its album \
art through MPris. Also, if it wouldn't crash whilst doing so, you could control \
Amarok when it's main window is closed if you have a launcher pinned to your task \
manager, basically rendering its tray icon obsolete.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works with VLC and Audacious, does not work with \
Dragon as the player announces itself as "dragonplayer" while its Desktop file says \
"dragon"</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(2a88886)</span></li>
<li>applets/taskmanager/package/contents/ui/ToolTipDelegate.qml <span style="color: \
grey">(4bf0b31)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126647/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/3058dacb-1dfd-464d-a1ec-be90bc9e58a8__mpristaskmanagerreview1.png">VLC \
with album art</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/6799d6f6-d505-4f56-9531-3013a3e34ae6__mpristaskmanagerreview2.png">Amarok \
without album art</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/06/25298761-28bb-4620-b768-dd0259f19b82__mpristaskmanagerreview3.png">No \
gradient</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/8dfcb9b6-6e11-4017-b4fc-70d92c9ded2a__mpristaskmanagerreview4.png">Raising \
Amarok through its launcher</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6200087773857775969==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic