'Re: Review Request 126300: Plasma Search KCM: display the runner descriptions'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126300: Plasma Search KCM: display the runner descriptions
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2016-01-07 13:50:23
Message-ID: 20160107135023.17116.79366 () mimi ! kde ! org
[Download RAW message or body]

--===============4798068426211208688==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 1:50 p.m.)

Review request for Plasma and KDE Usability.

Changes
-------

Diff updated in accordance with review comments.

Repository: plasma-desktop

Description
-------

In Plasma 5 this KCM only lists the names of the available runners, with no \
explanation of what they do.  In its previous incarnation in KDE4 (the dropdown list \
from the runner config button), the descriptions were displayed.  This change \
restores them.

Diffs (updated)
-----

  kcms/runners/kcm.h f1239ee 
  kcms/runners/kcm.cpp 4af82de 

Diff: https://git.reviewboard.kde.org/r/126300/diff/

Testing
-------

Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen \
and older styles.

File Attachments (updated)
----------------

Screenshot before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
 Screenshot after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
 Long lines truncated
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/f91d5bc6-eb02-49e1-b99a-337ee6823fec__plasmasearch-longlines-r126300.png

Thanks,

Jonathan Marten

--===============4798068426211208688==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126300/">https://git.reviewboard.kde.org/r/126300/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Jonathan Marten.</div>

<p style="color: grey;"><i>Updated Jan. 7, 2016, 1:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Diff updated in accordance with review comments.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In Plasma 5 this KCM only lists the names of the \
available runners, with no explanation of what they do.  In its previous incarnation \
in KDE4 (the dropdown list from the runner config button), the descriptions were \
displayed.  This change restores them.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built plasma-desktop with this change, checked \
appearance of KCM in Breeze, Oxygen and older styles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/runners/kcm.h <span style="color: grey">(f1239ee)</span></li>

 <li>kcms/runners/kcm.cpp <span style="color: grey">(4af82de)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126300/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png">Screenshot \
before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png">Screenshot \
after</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/f91d5bc6-eb02-49e1-b99a-337ee6823fec__plasmasearch-longlines-r126300.png">Long \
lines truncated</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4798068426211208688==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 