'Re: Review Request 126629: update the sddm kcm first step'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126629: update the sddm kcm first step
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2016-01-05 13:53:20
Message-ID: 20160105135320.6499.15942 () mimi ! kde ! org
[Download RAW message or body]

--===============1395591168435104640==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126629/#review90645
-----------------------------------------------------------

Ship it!

Ship It!

- David Edmundson

On Jan. 5, 2016, 2:34 a.m., Andreas ka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126629/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 2:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> -------
> 
> my first qml edit so I start with a small step one qml file.
> 
> can someone say me how to align right the second column. thanks
> 
> 
> Diffs
> -----
> 
> src/qml/main.qml 0f71aef 
> 
> Diff: https://git.reviewboard.kde.org/r/126629/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> how it looks after the update see preview section
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/8561c1e7-8d68-45b1-9bc2-23342a762071__sddm-kcm.png
>  
> 
> Thanks,
> 
> Andreas ka
> 
> 

--===============1395591168435104640==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126629/">https://git.reviewboard.kde.org/r/126629/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On January 5th, 2016, 2:34 a.m. UTC, Andreas ka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Andreas ka.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2016, 2:34 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
sddm-kcm
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">my first qml edit so I start with a small step one qml \
file.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">can someone say me how to align right the second \
column. thanks</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qml/main.qml <span style="color: grey">(0f71aef)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126629/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/8561c1e7-8d68-45b1-9bc2-23342a762071__sddm-kcm.png">how \
it looks after the update see preview section</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1395591168435104640==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 