'Re: Review Request 126373: change the taskbar color from blue to gray'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126373: change the taskbar color from blue to gray
From:       "andreas kainz" <kainz.a () gmail ! com>
Date:       2016-01-05 12:00:26
Message-ID: 20160105120026.6499.47722 () mimi ! kde ! org
[Download RAW message or body]

--===============5907670403678945430==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/
-----------------------------------------------------------

(Updated Jan. 5, 2016, noon)

Status
------

This change has been marked as submitted.

Review request for Plasma, Marco Martin and Uri Herrera.

Changes
-------

Submitted with commit 5af3ed10d98f4e65c4a056e99705b04d81d19ea7 by Marco Martin to \
branch master.

Repository: plasma-framework

Description
-------

Problem
=======
with the new taskbar we look that the look and feel is consistent between plasma and \
the applications therefore Uri change the selected application taskbar button to a \
blue background. The problem is that the blue background couldn't be the same blue \
than e.g. in the dolphin sidebar cause when you select an element in the sidebar the \
text color change from "black" to white which isn't possible in the system tray and \
than the contrast isn't that good in the panel for selected application (gray text on \
blue background). In addition the blue is very visible. see screenshot before.

Solution
========
I like that we use the same color language but when you look at the dolphin toolbar \
on top selected elements (e.g. preview in the screenshot) are gray so I change the \
blue color for the selected application to gray and change minimized app to no \
border.

what do you think?

Diffs
-----

  src/desktoptheme/breeze/widgets/tasks.svgz 086558b 

Diff: https://git.reviewboard.kde.org/r/126373/diff/

Testing
-------

I will test the new taskbar and hope someone else can test it too before we may ship \
it.

File Attachments
----------------

taskbar style old
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png
 taskbar style new
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png
 new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz
 taskbar old and new
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png
 tasks new blue boarder in difference to the original one
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz
 new draft, origin, old draft
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png

Thanks,

andreas kainz

--===============5907670403678945430==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126373/">https://git.reviewboard.kde.org/r/126373/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Marco Martin and Uri Herrera.</div>
<div>By andreas kainz.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2016, noon</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5af3ed10d98f4e65c4a056e99705b04d81d19ea7 by Marco \
Martin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Problem</h1> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">with the new taskbar we look that the look and feel is consistent between \
plasma and the applications therefore Uri change the selected application taskbar \
button to a blue background. The problem is that the blue background couldn't be the \
same blue than e.g. in the dolphin sidebar cause when you select an element in the \
sidebar the text color change from "black" to white which isn't possible in the \
system tray and than the contrast isn't that good in the panel for selected \
application (gray text on blue background). In addition the blue is very visible. see \
screenshot before.</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Solution</h1> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I like that we use the same color language but when you look at the dolphin \
toolbar on top selected elements (e.g. preview in the screenshot) are gray so I \
change the blue color for the selected application to gray and change minimized app \
to no border.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">what do you think?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I will test the new taskbar and hope someone else can \
test it too before we may ship it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/desktoptheme/breeze/widgets/tasks.svgz <span style="color: \
grey">(086558b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126373/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png">taskbar \
style old</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png">taskbar \
style new</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz">new \
tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png">taskbar \
old and new</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz">tasks \
new blue boarder in difference to the original one</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png">new \
draft, origin, old draft</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5907670403678945430==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 