[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126381: kwayland backend for libkscreen
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2016-01-04 22:40:10
Message-ID: 20160104224010.6499.21441 () mimi ! kde ! org
[Download RAW message or body]
--===============1055862625904863768==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote:
> > backends/CMakeLists.txt, line 3
> > <https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3>
> >
> > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be marked \
> > as required in top CMakeLists.tyt
>
> Sebastian Kügler wrote:
> KF5Wayland is required in top-level CMakeLists.txt. Where did you see that it \
> isn't?
> find_package(KF5Wayland CONFIG)
There's no REQUIRED keyword here AFAICS
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126381/#review90076
-----------------------------------------------------------
On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126381/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 12:46 a.m.)
>
>
> Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.
>
>
> Repository: libkscreen
>
>
> Description
> -------
>
> This adds a kwayland backend to libkscreen.
>
> This backend uses KWayland's OutputManagement protocol for enlisting and
> configuring devices.
>
> Enlisting outputs
>
> KScreen's outputs are created from KWayland::Client::OutputDevice objects,
> they copy the data into kscreen's Outputs, and update these objects. A list
> of outputs is requested from the client Registry object.
>
> Configuring outputs
>
> The backend asks the global OutputManagement interface for an OutputConfiguration
> object, then sets the changes per outputdevice on this object, and asks the
> compositor to apply() this configuration.
>
> For this to work, the compositor should support the Wayland \
> org_kde_kwin_outputdevice and org_kde_kwin_outputmanagement protocols, for example \
> through KWayland::Server classes OutputDevice, OutputManagmenent and \
> OuputConfiguration.
> General working
>
> WaylandBackend creates a global static internal config, available through
> WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry
> callbacks and catches org_kde_kwin_outputdevice creation and destruction.
> It passes org_kde_kwin_outputdevice creation and removal on to
> WB::internalConfig() to handle its internal data representation as WaylandOutput.
> WaylandOutput binds to org_kde_kwin_outputdevice's callback, and gets notified
> of geometry and modes, including changes. WaylandOutput administrates the
> internal representation of these objects, and invokes the global notifier,
> which then runs the pointers it holds through the updateK* methods in
> Wayland{Screen,Output,...}.
>
> KScreen:{Screen,Output,Edid,Mode} objects are created from the internal
> representation as requested (usually triggered by the creation of a
> KScreen::Config object through KScreen::Config::current()). As with other
> backends, the objects which are handed out to the lib's user are expected
> to be deleted by the user, the backend only takes ownership of its internal
> data representation objects.
>
>
> Diffs
> -----
>
> CMakeLists.txt efac5ce
> autotests/CMakeLists.txt 07b7bbc
> autotests/configs/default.json 3ac3e19
> autotests/testconfigserializer.cpp 1af3069
> autotests/testkwaylandbackend.cpp PRE-CREATION
> autotests/testkwaylandconfig.cpp PRE-CREATION
> backends/CMakeLists.txt ff5d751
> backends/kwayland/CMakeLists.txt PRE-CREATION
> backends/kwayland/README.md PRE-CREATION
> backends/kwayland/waylandbackend.h PRE-CREATION
> backends/kwayland/waylandbackend.cpp PRE-CREATION
> backends/kwayland/waylandconfig.h PRE-CREATION
> backends/kwayland/waylandconfig.cpp PRE-CREATION
> backends/kwayland/waylandoutput.h PRE-CREATION
> backends/kwayland/waylandoutput.cpp PRE-CREATION
> backends/kwayland/waylandscreen.h PRE-CREATION
> backends/kwayland/waylandscreen.cpp PRE-CREATION
> src/backendmanager.cpp 89ae31e
> src/config.cpp e8b8a8f
> src/screen.h 4cd1e82
> tests/CMakeLists.txt d5e41d5
> tests/kwayland/CMakeLists.txt PRE-CREATION
> tests/kwayland/main.cpp PRE-CREATION
> tests/kwayland/waylandconfigreader.h PRE-CREATION
> tests/kwayland/waylandconfigreader.cpp PRE-CREATION
> tests/kwayland/waylandtestserver.h PRE-CREATION
> tests/kwayland/waylandtestserver.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126381/diff/
>
>
> Testing
> -------
>
> The patch contains a test server, which is used for the autotests.
>
> The test server uses KWayland's server classes and is set up from the json config \
> data we use for the other tests. That means that the backends runs against a real \
> server to test everything.
> I also tested the kscreen UI, which also works as expected.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
--===============1055862625904863768==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126381/">https://git.reviewboard.kde.org/r/126381/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 24th, 2015, 9:23 p.m. CET, <b>Hrvoje \
Senjan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3" \
style="color: black; font-weight: bold; text-decoration: \
underline;">backends/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">3</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">add_subdirectory</span><span class="p">(</span><span \
class="s">kwayland</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be \
marked as required in top CMakeLists.tyt</p></pre> </blockquote>
<p>On January 4th, 2016, 10:52 p.m. CET, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KF5Wayland is required in top-level CMakeLists.txt. Where did you see that \
it isn't?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">find_package(KF5Wayland CONFIG)</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There's no REQUIRED keyword here AFAICS</p></pre> <br \
/>
<p>- Hrvoje</p>
<br />
<p>On December 22nd, 2015, 12:46 a.m. CET, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Solid, Daniel Vrátil, and Martin Gräßlin.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2015, 12:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a kwayland backend to libkscreen.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This backend uses KWayland's OutputManagement protocol for enlisting and \
configuring devices.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Enlisting outputs</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KScreen's outputs are created from KWayland::Client::OutputDevice objects, \
they copy the data into kscreen's Outputs, and update these objects. A list of \
outputs is requested from the client Registry object.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Configuring outputs</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The backend asks the \
global OutputManagement interface for an OutputConfiguration object, then sets the \
changes per outputdevice on this object, and asks the compositor to apply() this \
configuration.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">For this to work, the compositor should \
support the Wayland org_kde_kwin_outputdevice and org_kde_kwin_outputmanagement \
protocols, for example through KWayland::Server classes OutputDevice, \
OutputManagmenent and OuputConfiguration.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">General working</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">WaylandBackend creates a global static internal config, available through \
WaylandBackend::internalConfig(). WaylandConfig binds to the wl_registry callbacks \
and catches org_kde_kwin_outputdevice creation and destruction. It passes \
org_kde_kwin_outputdevice creation and removal on to WB::internalConfig() to handle \
its internal data representation as WaylandOutput. WaylandOutput binds to \
org_kde_kwin_outputdevice's callback, and gets notified of geometry and modes, \
including changes. WaylandOutput administrates the internal representation of these \
objects, and invokes the global notifier, which then runs the pointers it holds \
through the updateK* methods in Wayland{Screen,Output,...}.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KScreen:{Screen,Output,Edid,Mode} objects are created \
from the internal representation as requested (usually triggered by the creation of a
KScreen::Config object through KScreen::Config::current()). As with other
backends, the objects which are handed out to the lib's user are expected
to be deleted by the user, the backend only takes ownership of its internal
data representation objects.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The patch contains a test server, which is used for \
the autotests.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The test server uses KWayland's server \
classes and is set up from the json config data we use for the other tests. That \
means that the backends runs against a real server to test everything.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I also tested the kscreen UI, which also works as expected.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(efac5ce)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(07b7bbc)</span></li>
<li>autotests/configs/default.json <span style="color: grey">(3ac3e19)</span></li>
<li>autotests/testconfigserializer.cpp <span style="color: \
grey">(1af3069)</span></li>
<li>autotests/testkwaylandbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/testkwaylandconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/CMakeLists.txt <span style="color: grey">(ff5d751)</span></li>
<li>backends/kwayland/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/README.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandbackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandoutput.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandoutput.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandscreen.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/kwayland/waylandscreen.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/backendmanager.cpp <span style="color: grey">(89ae31e)</span></li>
<li>src/config.cpp <span style="color: grey">(e8b8a8f)</span></li>
<li>src/screen.h <span style="color: grey">(4cd1e82)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(d5e41d5)</span></li>
<li>tests/kwayland/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kwayland/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/kwayland/waylandconfigreader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kwayland/waylandconfigreader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kwayland/waylandtestserver.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tests/kwayland/waylandtestserver.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126381/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1055862625904863768==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic