'Re: Review Request 126348: Make it possible to provide the metadata in json'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126348: Make it possible to provide the metadata in json
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2016-01-04 19:04:02
Message-ID: 20160104190402.6499.4486 () mimi ! kde ! org
[Download RAW message or body]

--===============3952232426631669971==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 8:04 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Repository: kpackage

Description
-------

Due to KCoreAddons transition from using desktop files to json files, KPackage ended \
in a weird state where desktop files were allowed to use desktop files but not json.

This patch makes sure that manifest.json files are also acceptable.

Diffs
-----

  autotests/data/testjsonmetadatapackage/contents/ui/main.qml PRE-CREATION 
  autotests/data/testjsonmetadatapackage/metadata.json PRE-CREATION 
  autotests/querytest.cpp 0a2f11a 
  src/kpackage/package.cpp 8416054 
  src/kpackage/packageloader.cpp 1e1e382 
  src/kpackage/private/packagejobthread.cpp 444dacc 
  src/kpackage/private/packages.cpp 2f6bbcf 

Diff: https://git.reviewboard.kde.org/r/126348/diff/

Testing
-------

Tests still pass (except for \
https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, \
that is not passing in master). Adds a test plugin with a json file in it.

Thanks,

Aleix Pol Gonzalez

--===============3952232426631669971==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126348/">https://git.reviewboard.kde.org/r/126348/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Jan. 4, 2016, 8:04 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Due to KCoreAddons transition from using desktop files \
to json files, KPackage ended in a weird state where desktop files were allowed to \
use desktop files but not json.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch makes sure \
that manifest.json files are also acceptable.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tests still pass (except for \
https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, \
that is not passing in master). Adds a test plugin with a json file in it.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/data/testjsonmetadatapackage/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/data/testjsonmetadatapackage/metadata.json <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>autotests/querytest.cpp <span style="color: grey">(0a2f11a)</span></li>

 <li>src/kpackage/package.cpp <span style="color: grey">(8416054)</span></li>

 <li>src/kpackage/packageloader.cpp <span style="color: grey">(1e1e382)</span></li>

 <li>src/kpackage/private/packagejobthread.cpp <span style="color: \
grey">(444dacc)</span></li>

 <li>src/kpackage/private/packages.cpp <span style="color: \
grey">(2f6bbcf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126348/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3952232426631669971==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 