[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126548: Kill PowerDevil runner
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2016-01-04 8:32:29
Message-ID: 20160104083229.6499.26022 () mimi ! kde ! org
[Download RAW message or body]
--===============4040276059602241351==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote:
> > I can see that it provides suspend, sleep, hibernate feature which is still \
> > useful (Though for some reason I can't trigger it here). Maybe merge that part \
> > into sessions runner and drop others?
>
> Aleix Pol Gonzalez wrote:
> I often suspend from KRunner.
>
> Kai Uwe Broulik wrote:
> What's wrong about:
> * Using Kickoff
> * Using the Lock Logout applet
> * Pressing a shortcut on your keyboard
> * Closing the lid
> * Pressing the power button if configured to suspend
>
> Kai Uwe Broulik wrote:
> Crap, that should have become a list.
>
> Aleix Pol Gonzalez wrote:
> Maybe I could fit one of those solutions, I just don't see why it needs to be \
> removed.
> I mostly use KRunner when I have 2 monitors, so closing the lid would just leave it \
> to the other monitor. I don't think I have such a shortcut and I removed kickoff \
> longtime ago because I only used it to suspend my system :D.
> Kai Uwe Broulik wrote:
> > D Fair enough.
>
> I'll clean it up, though, remove all the brightness and profile cruft.
just for the record: most of the times I suspend my system by opening krunner and \
entering suspend. So https://xkcd.com/1172/ applies
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
-----------------------------------------------------------
On Dec. 28, 2015, 7:28 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:28 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
>
>
> Diffs
> -----
>
> runners/CMakeLists.txt 48cc379
> runners/powerdevil/CMakeLists.txt 7c03e29
> runners/powerdevil/Messages.sh 99ae5dc
> runners/powerdevil/PowerDevilRunner.h 7995621
> runners/powerdevil/PowerDevilRunner.cpp 527a2c2
> runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e
>
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============4040276059602241351==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126548/">https://git.reviewboard.kde.org/r/126548/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 28th, 2015, 6:46 p.m. CET, <b>Xuetian \
Weng</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I can see that it provides suspend, sleep, hibernate \
feature which is still useful (Though for some reason I can't trigger it here). Maybe \
merge that part into sessions runner and drop others?</p></pre> </blockquote>
<p>On December 28th, 2015, 6:50 p.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
often suspend from KRunner.</p></pre> </blockquote>
<p>On December 28th, 2015, 6:58 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What's wrong about: <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;"> Using Kickoff </em> Using the Lock \
Logout applet <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> Pressing a shortcut on your keyboard </em> Closing the \
lid
* Pressing the power button if configured to suspend</p></pre>
</blockquote>
<p>On December 28th, 2015, 6:58 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Crap, \
that should have become a list.</p></pre> </blockquote>
<p>On December 28th, 2015, 7:24 p.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
I could fit one of those solutions, I just don't see why it needs to be removed.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I mostly use KRunner when I have 2 monitors, so \
closing the lid would just leave it to the other monitor. I don't think I have such a \
shortcut and I removed kickoff longtime ago because I only used it to suspend my \
system :D.</p></pre> </blockquote>
<p>On December 28th, 2015, 7:28 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">:D \
Fair enough.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'll clean it up, though, remove all the brightness \
and profile cruft.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
for the record: most of the times I suspend my system by opening krunner and entering \
suspend. So https://xkcd.com/1172/ applies</p></pre> <br />
<p>- Martin</p>
<br />
<p>On December 28th, 2015, 7:28 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2015, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I have no idea how to \
use it</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">I have never used it</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">It \
allows switching profiles which were removed half a decade ago</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Its brightness handling is most likely broken</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">There's global keyboard shorcuts and battery monitor</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">I'm not willing to maintain it and/or ensure it keeps working</li> \
</ul></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: grey">(48cc379)</span></li>
<li>runners/powerdevil/CMakeLists.txt <span style="color: \
grey">(7c03e29)</span></li>
<li>runners/powerdevil/Messages.sh <span style="color: grey">(99ae5dc)</span></li>
<li>runners/powerdevil/PowerDevilRunner.h <span style="color: \
grey">(7995621)</span></li>
<li>runners/powerdevil/PowerDevilRunner.cpp <span style="color: \
grey">(527a2c2)</span></li>
<li>runners/powerdevil/plasma-runner-powerdevil.desktop <span style="color: \
grey">(647f66e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126548/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4040276059602241351==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic