[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124047: Improve clock's tooltip layout
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-12-31 20:55:17
Message-ID: 20151231205517.12515.17628 () mimi ! kde ! org
[Download RAW message or body]
--===============7778751286962867301==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 31, 2015, 9:47 p.m., Kai Uwe Broulik wrote:
> > you're now sorting in two separate places. can't you have one function in qml and \
> > sort in both component completed and in on selected timezones changed?
No; sorting the array in onSelectingTimeZonesChanged (and setting it to \
plasmoid.configuration.selectedTimeZones) triggers the Changed signal and it makes \
inifinite recursive call.
Plus, the first place is the applet and the second place is the configuration \
interface model, which are different places...technically anyway.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review90384
-----------------------------------------------------------
On Dec. 31, 2015, 9:40 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 9:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348078
> https://bugs.kde.org/show_bug.cgi?id=348078
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now \
> it's a bit of a mess so this brings back the table.
> Also simplifies the timeForZone function which is used only for the tooltip.
>
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9
> applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION
> applets/digital-clock/package/contents/ui/main.qml e754925
> applets/digital-clock/plugin/timezonedata.h 682b7c7
> applets/digital-clock/plugin/timezonemodel.h 39f64f4
> applets/digital-clock/plugin/timezonemodel.cpp 2fe7b16
>
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============7778751286962867301==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124047/">https://git.reviewboard.kde.org/r/124047/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 31st, 2015, 9:47 p.m. CET, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">you're now sorting in two separate places. can't you \
have one function in qml and sort in both component completed and in on selected \
timezones changed?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No; \
sorting the array in onSelectingTimeZonesChanged (and setting it to \
plasmoid.configuration.selectedTimeZones) triggers the Changed signal and it makes \
inifinite recursive call.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Plus, the first place is the applet and \
the second place is the configuration interface model, which are different \
places...technically anyway.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On December 31st, 2015, 9:40 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2015, 9:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348078">348078</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In kde4 times, the layout of clock's tooltip was \
nicely arranged using a table. Now it's a bit of a mess so this brings back the \
table.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also simplifies the timeForZone function which is used \
only for the tooltip.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See screenshots.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(56e31b9)</span></li>
<li>applets/digital-clock/package/contents/ui/Tooltip.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/package/contents/ui/main.qml <span style="color: \
grey">(e754925)</span></li>
<li>applets/digital-clock/plugin/timezonedata.h <span style="color: \
grey">(682b7c7)</span></li>
<li>applets/digital-clock/plugin/timezonemodel.h <span style="color: \
grey">(39f64f4)</span></li>
<li>applets/digital-clock/plugin/timezonemodel.cpp <span style="color: \
grey">(2fe7b16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124047/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7778751286962867301==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic