[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126356: change minimum size of clipboard
From: "andreas kainz" <kainz.a () gmail ! com>
Date: 2015-12-31 0:09:06
Message-ID: 20151231000906.30660.90678 () mimi ! kde ! org
[Download RAW message or body]
--===============6766046031156841561==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote:
> > applets/clipboard/contents/ui/clipboard.qml, line 69
> > <https://git.reviewboard.kde.org/r/126356/diff/1/?file=422789#file422789line69>
> >
> > this is not the actual size of the systray, but a hardcoded value which might \
> > match (or not) the size of systray.
> > As the motivation sounds correct to me I suggest to find a way to actually use \
> > the size of systray. Experts around?
>
> andreas kainz wrote:
> it doesn't have to have the same size than in the system tray popup. I only want to \
> reduce the minimum height so that the minimum height would be at least the height \
> of the popup. it's only a preset value. you don't have to investigate to much time. \
> use a number would be ok. and it doesn't matter what would be the minimum size the \
> user have to change the plasmoid size by themself at the desktop so it is not a \
> predefinition.
would be also ok to use the system tray size but where is the system tray size \
defined?
- andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/#review89547
-----------------------------------------------------------
On Dec. 15, 2015, 12:37 p.m., andreas kainz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126356/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 12:37 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> if you use clipboard on the desktop the minimum window height is heigher than you \
> use clipboard from the panel (drop down window). As the user can define the width \
> and height for the desktop plasmoid the minimum allowed height should be at least \
> the same than the drop down window in the panel. so I change the minimumHeig to 16. \
>
> Diffs
> -----
>
> applets/clipboard/contents/ui/clipboard.qml 97230c1
>
> Diff: https://git.reviewboard.kde.org/r/126356/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> old before with 26 min height
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
> new after with 16 min height
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
>
>
> Thanks,
>
> andreas kainz
>
>
--===============6766046031156841561==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126356/">https://git.reviewboard.kde.org/r/126356/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 15th, 2015, 2:29 p.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126356/diff/1/?file=422789#file422789line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/clipboard/contents/ui/clipboard.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">69</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">Layout.minimumHeight:</span> <span class="nx">units</span><span \
class="p">.</span><span class="nx">gridUnit</span> <span class="o">*</span> <span \
class="mi"><span class="hl">2</span>6</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">69</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">Layout.minimumHeight:</span> <span class="nx">units</span><span \
class="p">.</span><span class="nx">gridUnit</span> <span class="o">*</span> <span \
class="mi"><span class="hl">1</span>6</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
is not the actual size of the systray, but a hardcoded value which might match (or \
not) the size of systray.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As the motivation sounds correct to me \
I suggest to find a way to actually use the size of systray. Experts \
around?</p></pre> </blockquote>
<p>On December 15th, 2015, 11:38 p.m. UTC, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it \
doesn't have to have the same size than in the system tray popup. I only want to \
reduce the minimum height so that the minimum height would be at least the height of \
the popup. it's only a preset value. you don't have to investigate to much time. use \
a number would be ok. and it doesn't matter what would be the minimum size the user \
have to change the plasmoid size by themself at the desktop so it is not a \
predefinition.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">would be also ok to use the system tray size but where is the system tray \
size defined?</p></pre> <br />
<p>- andreas</p>
<br />
<p>On December 15th, 2015, 12:37 p.m. UTC, andreas kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By andreas kainz.</div>
<p style="color: grey;"><i>Updated Dec. 15, 2015, 12:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if you use clipboard on the desktop the minimum window \
height is heigher than you use clipboard from the panel (drop down window). As the \
user can define the width and height for the desktop plasmoid the minimum allowed \
height should be at least the same than the drop down window in the panel. so I \
change the minimumHeig to 16.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/clipboard/contents/ui/clipboard.qml <span style="color: \
grey">(97230c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126356/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png">old \
before with 26 min height</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png">new \
after with 16 min height</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6766046031156841561==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic