'Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results
From:       "Thomas Pfeiffer" <colomar () autistici ! org>
Date:       2015-12-30 22:01:32
Message-ID: 20151230220132.30660.58875 () mimi ! kde ! org
[Download RAW message or body]

--===============0459622047170451506==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126578/#review90361
-----------------------------------------------------------

Looks great, no objections!

- Thomas Pfeiffer

On Dec. 30, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126578/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds the context menu actions you also get in the favorites and applications \
> view to search results. 
> Usability: This enables this for Kickoff, Kicker and Application Dashboard.
> 
> I did not add the "Edit application" context menu as search results are somewhat \
> conceptually detached from the application menu structure. 
> 
> Diffs
> -----
> 
> applets/kicker/package/contents/ui/main.qml 5defa75 
> applets/kicker/plugin/actionlist.h 58dd6dd 
> applets/kicker/plugin/actionlist.cpp 6d73434 
> applets/kicker/plugin/appentry.cpp 61fd8a9 
> applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
> applets/kicker/plugin/runnermodel.h 4c3f212 
> applets/kicker/plugin/runnermodel.cpp 6496816 
> applets/kickoff/package/contents/ui/Kickoff.qml 8a8c9c5 
> 
> Diff: https://git.reviewboard.kde.org/r/126578/diff/
> 
> 
> Testing
> -------
> 
> Steam favorite: Add to desktop, panel, task manager work, "Screenshots" jump list \
> action works 
> Searched for "steam": Add to desktop, panel, task manager work, "Screenshots" jump \
> list action works 
> 
> File Attachments
> ----------------
> 
> Search result menu
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/2e00c239-3dcc-4253-9c0c-0563a11de9b2__steaminsearch.jpg
>  
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============0459622047170451506==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126578/">https://git.reviewboard.kde.org/r/126578/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
great, no objections!</p></pre>  <br />

<p>- Thomas Pfeiffer</p>

<br />
<p>On December 30th, 2015, 7:09 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability and Eike Hein.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2015, 7:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds the context menu actions you also get in the \
favorites and applications view to search results.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Usability: This enables this for Kickoff, Kicker and Application \
Dashboard.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I did not add the "Edit application" context menu as \
search results are somewhat conceptually detached from the application menu \
structure.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Steam favorite: Add to desktop, panel, task manager \
work, "Screenshots" jump list action works</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Searched for "steam": \
Add to desktop, panel, task manager work, "Screenshots" jump list action \
works</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kicker/package/contents/ui/main.qml <span style="color: \
grey">(5defa75)</span></li>

 <li>applets/kicker/plugin/actionlist.h <span style="color: \
grey">(58dd6dd)</span></li>

 <li>applets/kicker/plugin/actionlist.cpp <span style="color: \
grey">(6d73434)</span></li>

 <li>applets/kicker/plugin/appentry.cpp <span style="color: \
grey">(61fd8a9)</span></li>

 <li>applets/kicker/plugin/runnermatchesmodel.cpp <span style="color: \
grey">(b6b1b0f)</span></li>

 <li>applets/kicker/plugin/runnermodel.h <span style="color: \
grey">(4c3f212)</span></li>

 <li>applets/kicker/plugin/runnermodel.cpp <span style="color: \
grey">(6496816)</span></li>

 <li>applets/kickoff/package/contents/ui/Kickoff.qml <span style="color: \
grey">(8a8c9c5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126578/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/2e00c239-3dcc-4253-9c0c-0563a11de9b2__steaminsearch.jpg">Search \
result menu</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0459622047170451506==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 