--===============1411617815434240530== Content-Type: multipart/alternative; boundary="===============6609119236265904259==" --===============6609119236265904259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/ ----------------------------------------------------------- (Updated Dec. 30, 2015, 5:05 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, KDE Usability and Martin Klapetek. Changes ------- Submitted with commit be4b0f5aacb9f6550d4e4d0f7226c9e78acd63b5 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description ------- It's nice that we offer to configure notifications from a notification. Usually, however, you're lost in a dialog notifications and you have no idea which event you actually just saw. Diffs ----- applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c applets/notifications/package/contents/ui/NotificationPopup.qml d398027 applets/notifications/package/contents/ui/Notifications.qml f479a65 dataengines/notifications/notificationaction.cpp da5ba14 dataengines/notifications/notifications.operations d2a120a dataengines/notifications/notificationsengine.h b275830 dataengines/notifications/notificationsengine.cpp 829ef4e Diff: https://git.reviewboard.kde.org/r/126570/diff/ Testing ------- I now get the actual notification highlighted when I press the configure button of one. Neat. File Attachments ---------------- Highlighted notification https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png Thanks, Kai Uwe Broulik --===============6609119236265904259== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/

This change has been marked as submitted.

Review request for Plasma, KDE Usability and Martin Klapetek.
By Kai Uwe Broulik.

Updated Dec. 30, 2015, 5:05 p.m.

Changes

Submitted with commit be4b0f5aacb9f6550d4e4d0f7226c9e78acd63b5 by Kai Uwe Broulik to branch master.
Repository: plasma-workspace

Description 

It's nice that we offer to configure notifications from a notification. Usually, however, you're lost in a dialog notifications and you have no idea which event you actually just saw.

Testing 

I now get the actual notification highlighted when I press the configure button of one. Neat.

Diffs

  • applets/notifications/package/contents/ui/NotificationDelegate.qml (fde115c)
  • applets/notifications/package/contents/ui/NotificationPopup.qml (d398027)
  • applets/notifications/package/contents/ui/Notifications.qml (f479a65)
  • dataengines/notifications/notificationaction.cpp (da5ba14)
  • dataengines/notifications/notifications.operations (d2a120a)
  • dataengines/notifications/notificationsengine.h (b275830)
  • dataengines/notifications/notificationsengine.cpp (829ef4e)

View Diff

File Attachments

  • Highlighted notification
    		•
    --===============6609119236265904259==-- --===============1411617815434240530== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1411617815434240530==--