'Re: Review Request 126278: [Icon Widget] Add support for Jump Lists'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126278: [Icon Widget] Add support for Jump Lists
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-12-30 16:56:33
Message-ID: 20151230165633.30660.53026 () mimi ! kde ! org
[Download RAW message or body]

--===============2139778224187905191==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126278/
-----------------------------------------------------------

(Updated Dec. 30, 2015, 4:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Bhushan Shah.

Changes
-------

Submitted with commit 4d88904c4f630ca42d33c2c303de37675fc576d1 by Kai Uwe Broulik to \
branch master.

Repository: plasma-workspace

Description
-------

This adds support for Desktop Actions aka Jump Lists to the icon widget to make them \
on par with launchers.

Diffs
-----

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126278/diff/

Testing
-------

I get New Tab/New Incognito in Chromium context menu.

I didn't test what happens if I change the URL (whether it properly updates them). \
Also the patch has some unrelated changes from Review 126149

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/08/e6f80a92-8120-414f-840a-120c791b3ebf__jumplisticon.png

Thanks,

Kai Uwe Broulik

--===============2139778224187905191==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126278/">https://git.reviewboard.kde.org/r/126278/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Bhushan Shah.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2015, 4:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 4d88904c4f630ca42d33c2c303de37675fc576d1 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds support for Desktop Actions aka Jump Lists \
to the icon widget to make them on par with launchers.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I get New Tab/New Incognito in Chromium context \
menu.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I didn't test what happens if I change the URL \
(whether it properly updates them). Also the patch has some unrelated changes from \
Review 126149</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icon/package/contents/ui/main.qml <span style="color: \
grey">(9286b94)</span></li>

 <li>applets/icon/plugin/icon_p.h <span style="color: grey">(dd7963c)</span></li>

 <li>applets/icon/plugin/icon_p.cpp <span style="color: grey">(e086870)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126278/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/08/e6f80a92-8120-414f-840a-120c791b3ebf__jumplisticon.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2139778224187905191==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 