From kde-panel-devel Wed Dec 30 16:10:18 2015 From: "David Edmundson" Date: Wed, 30 Dec 2015 16:10:18 +0000 To: kde-panel-devel Subject: Re: Review Request 126576: Don't emit signals in another object from panel. Message-Id: <20151230161018.30660.84845 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145149184123779 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7955739431757977235==" --===============7955739431757977235== Content-Type: multipart/alternative; boundary="===============5684603850329598580==" --===============5684603850329598580== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ ----------------------------------------------------------- (Updated Dec. 30, 2015, 4:10 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit c62452c467e96756a4e5bcaddcee98caa7d27d49 by David Edmundson to branch master. Repository: plasma-workspace Description ------- Emitting objects in another object is generally bad practice. ShellCorona::availableScreenRect knows what properties of panelview we use, so tracking of property changes should be in ShellCorona. Diffs ----- shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd Diff: https://git.reviewboard.kde.org/r/126576/diff/ Testing ------- Thanks, David Edmundson --===============5684603850329598580== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/

This change has been marked as submitted.

Review request for Plasma.
By David Edmundson.

Updated Dec. 30, 2015, 4:10 p.m.

Changes

Submitted with commit c62452c467e96756a4e5bcaddcee98caa7d27d49 by David Edmundson to branch master.
Repository: plasma-workspace

Description 

Emitting objects in another object is generally bad practice.


ShellCorona::availableScreenRect knows what properties of panelview we
use, so tracking of property changes should be in ShellCorona.

Diffs

  • shell/panelview.cpp (553dc7da30d2169b5c723926e0d610e846b077f7)
  • shell/shellcorona.cpp (17ce61b57f71332b9b4029d44301462ef90d3dfd)

View Diff
--===============5684603850329598580==-- --===============7955739431757977235== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7955739431757977235==--