[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126576: Don't emit signals in another object from panel.
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-12-30 15:28:49
Message-ID: 20151230152849.30660.56443 () mimi ! kde ! org
[Download RAW message or body]
--===============1632112386788393455==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90343
-----------------------------------------------------------
Ship it!
looks good, i'm also not 100% convinced by the removal of that line even tough i \
agree with it, do a test show no regressions?
shell/panelview.cpp
<https://git.reviewboard.kde.org/r/126576/#comment61814>
was probably a workaround to setscreen not working? looks unrelated indeed, but \
if now works fine without this line it should be committed as well
- Marco Martin
On Dec. 30, 2015, noon, David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, noon)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Emitting objects in another object is generally bad practice.
>
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
>
>
> Diffs
> -----
>
> shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7
> shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd
>
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============1632112386788393455==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126576/">https://git.reviewboard.kde.org/r/126576/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looks \
good, i'm also not 100% convinced by the removal of that line even tough i agree with \
it, do a test show no regressions?</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126576/diff/1/?file=427794#file427794line67" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/panelview.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">PanelView::PanelView(ShellCorona *corona, QScreen *targetScreen, QWindow \
*parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">67</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setPosition</span><span class="p">(</span><span \
class="n">targetScreen</span><span class="o">-></span><span \
class="n">geometry</span><span class="p">().</span><span class="n">center</span><span \
class="p">());</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">was \
probably a workaround to setscreen not working? looks unrelated indeed, but if now \
works fine without this line it should be committed as well</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On December 30th, 2015, noon UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2015, noon</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Emitting objects in another object is generally bad \
practice.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ShellCorona::availableScreenRect knows what properties \
of panelview we use, so tracking of property changes should be in \
ShellCorona.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/panelview.cpp <span style="color: \
grey">(553dc7da30d2169b5c723926e0d610e846b077f7)</span></li>
<li>shell/shellcorona.cpp <span style="color: \
grey">(17ce61b57f71332b9b4029d44301462ef90d3dfd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126576/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1632112386788393455==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic