From kde-panel-devel Tue Dec 29 21:39:01 2015 From: "David Edmundson" Date: Tue, 29 Dec 2015 21:39:01 +0000 To: kde-panel-devel Subject: Re: Review Request 126566: Add "applicationcrash" notification event Message-Id: <20151229213901.18086.19914 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145142516211856 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9056891989030024403==" --===============9056891989030024403== Content-Type: multipart/alternative; boundary="===============2911895841450410649==" --===============2911895841450410649== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/#review90309 ----------------------------------------------------------- Ship it! Ship It! - David Edmundson On Dec. 29, 2015, 9:22 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126566/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 9:22 p.m.) > > > Review request for Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > This adds a new "applicationcrash" event to be used for the DrKonqi notifications in Review 126515. > > The "Catastrophe" event, while mentioning "something bad happened, at least the app crashed", draws a lot of attention to it with its sound. Also, having a dedicated notification for this could allow users to specifically disable these DrKonqi messages in case they really don't care. > > > Diffs > ----- > > plasma_workspace.notifyrc 877096a > > Diff: https://git.reviewboard.kde.org/r/126566/diff/ > > > Testing > ------- > > Works, I get a Plasma notification without sound. > > > Thanks, > > Kai Uwe Broulik > > --===============2911895841450410649== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/

Ship it!

Ship It!

- David Edmundson

On December 29th, 2015, 9:22 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated Dec. 29, 2015, 9:22 p.m.

Repository: frameworkintegration

Description

This adds a new "applicationcrash" event to be used for the DrKonqi notifications in Review 126515.

The "Catastrophe" event, while mentioning "something bad happened, at least the app crashed", draws a lot of attention to it with its sound. Also, having a dedicated notification for this could allow users to specifically disable these DrKonqi messages in case they really don't care.

Testing

Works, I get a Plasma notification without sound.

Diffs

plasma_workspace.notifyrc (877096a)

View Diff

--===============2911895841450410649==-- --===============9056891989030024403== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9056891989030024403==--