From kde-panel-devel Tue Dec 29 20:12:37 2015 From: "Martin Klapetek" Date: Tue, 29 Dec 2015 20:12:37 +0000 To: kde-panel-devel Subject: Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification Message-Id: <20151229201237.18086.56010 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145141997610722 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4486928772524639052==" --===============4486928772524639052== Content-Type: multipart/alternative; boundary="===============4298182258536578813==" --===============4298182258536578813== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ ----------------------------------------------------------- (Updated Dec. 29, 2015, 8:12 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit f639996becc2fae284d9c83273856dee510b699d by Martin Klapetek to branch master. Bugs: 356653 http://bugs.kde.org/show_bug.cgi?id=356653 Repository: plasma-framework Description ------- https://git.reviewboard.kde.org/r/126459/ introduced new flag that allows to skip the grouping of notifications. This should fix all bugs caused by checking for appName being "plasma_workspace" which are all default notifications from any plasmoid. BUG: 356653 (this also needs to raise the KF5 dep to 5.18 which is normally done at release time, but in order to use this now, it needs to be bumped now, otherwise build failures will ensue) Diffs ----- CMakeLists.txt a27b3ac src/plasma/private/applet_p.cpp 511b451 Diff: https://git.reviewboard.kde.org/r/126461/diff/ Testing ------- Thanks, Martin Klapetek --===============4298182258536578813== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

By Martin Klapetek.

Updated Dec. 29, 2015, 8:12 p.m.

Changes

Submitted with commit f639996becc2fae284d9c83273856dee510b699d by Martin Klapetek to branch master.

Bugs: 356653

Repository: plasma-framework

Description

https://git.reviewboard.kde.org/r/126459/ introduced new flag that allows to skip the grouping of notifications.

This should fix all bugs caused by checking for appName being "plasma_workspace" which are all default notifications from any plasmoid.

BUG: 356653

(this also needs to raise the KF5 dep to 5.18 which is normally done at release time, but in order to use this now, it needs to be bumped now, otherwise build failures will ensue)

Diffs

CMakeLists.txt (a27b3ac)
src/plasma/private/applet_p.cpp (511b451)

View Diff

--===============4298182258536578813==-- --===============4486928772524639052== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4486928772524639052==--