[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124207: Use proper relative paths to import js code
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2015-12-29 15:01:22
Message-ID: 20151229150122.28777.38578 () mimi ! kde ! org
[Download RAW message or body]
--===============3695891444569463345==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124207/
-----------------------------------------------------------
(Updated Dec. 29, 2015, 3:01 p.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Use proper relative paths to import js code
Diffs
-----
applets/analog-clock/contents/ui/analogclock.qml edb3af94dff70e8f846783ffe1165fc8cf83beca
applets/batterymonitor/package/contents/ui/BatteryItem.qml a91286ceb5e502fdb2995627dd0a762c843d6a7a
applets/batterymonitor/package/contents/ui/CompactRepresentation.qml \
b4059cbe32f549cb06f34d18ebfa3261bc7a0d0f applets/batterymonitor/package/contents/ui/PopupDialog.qml \
d4952c61e701f7077b7d9dfcf084b4baf3951f0d applets/batterymonitor/package/contents/ui/batterymonitor.qml \
ce3a996a8e9024ac7d8d82b546be4aeed8011c74 applets/lock_logout/contents/ui/lockout.qml \
635389a3ca57845ed7b0c28511c4fbd8aad1951d applets/notifications/package/contents/ui/main.qml \
1fdd11abad41bc0b7f156be1409d9268f424a0ae applets/systemtray/package/contents/ui/main.qml \
e794d1ca436f94c044c5f532dd6fc7d6082d3576
Diff: https://git.reviewboard.kde.org/r/124207/diff/
Testing
-------
Thanks,
Kevin Ottens
--===============3695891444569463345==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124207/">https://git.reviewboard.kde.org/r/124207/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2015, 3:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use proper relative paths to import js \
code</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/analog-clock/contents/ui/analogclock.qml <span style="color: \
grey">(edb3af94dff70e8f846783ffe1165fc8cf83beca)</span></li>
<li>applets/batterymonitor/package/contents/ui/BatteryItem.qml <span style="color: \
grey">(a91286ceb5e502fdb2995627dd0a762c843d6a7a)</span></li>
<li>applets/batterymonitor/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(b4059cbe32f549cb06f34d18ebfa3261bc7a0d0f)</span></li>
<li>applets/batterymonitor/package/contents/ui/PopupDialog.qml <span style="color: \
grey">(d4952c61e701f7077b7d9dfcf084b4baf3951f0d)</span></li>
<li>applets/batterymonitor/package/contents/ui/batterymonitor.qml <span style="color: \
grey">(ce3a996a8e9024ac7d8d82b546be4aeed8011c74)</span></li>
<li>applets/lock_logout/contents/ui/lockout.qml <span style="color: \
grey">(635389a3ca57845ed7b0c28511c4fbd8aad1951d)</span></li>
<li>applets/notifications/package/contents/ui/main.qml <span style="color: \
grey">(1fdd11abad41bc0b7f156be1409d9268f424a0ae)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: \
grey">(e794d1ca436f94c044c5f532dd6fc7d6082d3576)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124207/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3695891444569463345==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic