'Re: Review Request 124204: Use proper relative paths to import js code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124204: Use proper relative paths to import js code
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-12-29 13:45:10
Message-ID: 20151229134510.18086.98350 () mimi ! kde ! org
[Download RAW message or body]

--===============7954355262221584338==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote:
> > this still seems to cause issues for some people.
> > May this series of patches be worth to push anyways?
> 
> David Edmundson wrote:
> > this still seems to cause issues for some people.
> 
> Where have you seen that? 
> I don't recall seeing any bug reports.

still happened to Kevin after qt, frameworks, and workspace were updated.
and yeah, still annoying to not have idea why that happens

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review90278
-----------------------------------------------------------

On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 7:15 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -----
> 
> src/applet/package/contents/ui/BluetoothApplet.qml \
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6  \
> src/applet/package/contents/ui/CompactRepresentation.qml \
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658  
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
> 

--===============7954355262221584338==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124204/">https://git.reviewboard.kde.org/r/124204/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 29th, 2015, 1:36 p.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this still seems to cause issues for some people. May \
this series of patches be worth to push anyways?</p></pre>  </blockquote>

 <p>On December 29th, 2015, 1:42 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">this still seems to cause issues for some people.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Where have you seen that?  I don't recall seeing any \
bug reports.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still \
happened to Kevin after qt, frameworks, and workspace were updated. and yeah, still \
annoying to not have idea why that happens</p></pre> <br />

<p>- Marco</p>

<br />
<p>On June 29th, 2015, 7:15 a.m. UTC, Kevin Ottens wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kevin Ottens.</div>

<p style="color: grey;"><i>Updated June 29, 2015, 7:15 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use proper relative paths to import js code</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(4e8b9648983edd2c8db242515464ae22d1e6fbe6)</span></li>

 <li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(7085a7ec82fa88cb2d8e1a58847215845f3d5658)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124204/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7954355262221584338==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 